Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML outputs are broken #301

Closed
TheRealAgentK opened this issue Jun 25, 2017 · 2 comments
Closed

HTML outputs are broken #301

TheRealAgentK opened this issue Jun 25, 2017 · 2 comments
Assignees
@TheRealAgentK
Labels
bug enhancement

Comments

@TheRealAgentK
Copy link
Collaborator

Ha - turns out that HTML Output relies on Findbugs XML - who'd have expected that it's being created THAT way... I just realised that today :-/

So - with me having brought the Findbugs output over to the modern XSD they publish, the old XSLT from Findbugs XML to HTML is kind of useless now (it's a template from 2004/5...).

htmlstyle plain --- renders, but is useless
htmlstyle default --- breaks, I have no idea why at this stage.

Will need to have a look at what our options are here.
@TheRealAgentK TheRealAgentK self-assigned this Jun 25, 2017
TheRealAgentK added a commit to TheRealAgentK/CFLint that referenced this issue Jun 25, 2017
@TheRealAgentK
cflint#301 (partly) Bringing back default.xsl so that -htmlstyle defa…
1327da5 
…ult stops breaking
TheRealAgentK added a commit that referenced this issue Jun 25, 2017
@TheRealAgentK
Merge pull request #302 from TheRealAgentK/dev
7744eb5 
Partial fix for #301
@TheRealAgentK
Copy link
Collaborator Author

I've put default.xsl back in place so that the output doesn't NPE anymore - the HTML templates for Findbugs->HTML still are not useful anymore and I'll have a look into what to replace them with.

TheRealAgentK added a commit to TheRealAgentK/CFLint that referenced this issue Jun 25, 2017
@TheRealAgentK
cflint#301 - exposing priority counts in Findbugs XML
db53698
TheRealAgentK added a commit to TheRealAgentK/CFLint that referenced this issue Jun 25, 2017
@TheRealAgentK
cflint#301 - Properly working plain template for HTML output
13630d4
TheRealAgentK added a commit to TheRealAgentK/CFLint that referenced this issue Jun 25, 2017
@TheRealAgentK
cflint#301 - Only create method element in Findbugs if we actually ha…
6f0b82b 
…ve a funciton in CFLint XML.
TheRealAgentK added a commit to TheRealAgentK/CFLint that referenced this issue Jun 25, 2017
@TheRealAgentK
cflint#301 - Copied plain.xsd over default.xsd - there's only margina…
176eeeb 
…l differences between them in Findbugs and most of them are historic goofing around and fixing stuff in one and not in the other one.
@TheRealAgentK
Copy link
Collaborator Author

TheRealAgentK commented Jun 25, 2017 •
edited
Loading

Closed.

-htmlstyle default and
-htmlstyle plain

are currently creating the same output.

The differences between were minor anyway. Probably we should change the code so that default becomes and alias to run plain.xsd (@ryaneberly?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheRealAgentK TheRealAgentK

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheRealAgentK