-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that PRs do not break Asciidoctor build #251
Conversation
As an example of what this will look like, see here. |
I agree this is a useful and sensible step thank you for the input @lesserwhirls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks well set up to me
Thanks @marqh! Happy to help where I can :-) |
This is great! |
This PR enables a github action to check that PRs do not break the asciidoc build. If the build is successful, the pdf and html files are uploaded as artifacts to the action, which allow for easier previews of the generated files.
That would be great! Currently, the
I've updated this PR to enable the asciidoctor build to use the |
Two positive reviews and it looks good to me. I'm going to merge. I will look at how to require reviews for this type of PR, probably by members of the info-mgmt team - @cf-convention/info-mgmt |
This PR enables a github action to check that PRs do not break the asciidoc build. If the build is successful, the pdf and html files are uploaded as artifacts to the action, which allow for easier previews of the generated files.