-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text method to element #8
Conversation
…when calling Tree()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I'll take a look |
…leri into add-text-method-to-element
@iamneal , Maybe we could add a Something like: // GetNodeString
func (r *Result) GetNodeString(n *Node) string {
return r.expression[n.start:n.end]
} This would require to parse the Node to the Result, but it keeps the Node struct light and does not unnecessary create a lot of new strings. (only when truly required). |
No description provided.