Add 5m timeout to bundle-test and make the computed catalog version stable #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #105 I notice that the GitHub Action keeps running long after it is clear that the installation check has shown failures.
https://github.com/cert-manager/cert-manager-olm/actions/runs/7813016364/job/21311278187?pr=105
I also noticed that when I ran
make bundle-test
locally, and continued editing the files while the test was ongoing,the computed catalog version changed between the running of an early make rule and a later make rule.
So I compute that version once when the makefile is parsed and use that as the default for all rules.