Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5m timeout to bundle-test and make the computed catalog version stable #106

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Feb 7, 2024

While testing #105 I notice that the GitHub Action keeps running long after it is clear that the installation check has shown failures.

0s          Warning   BackOff               pod/cert-manager-webhook-6988db7859-fk5h5        Back-off restarting failed container cert-manager-webhook in pod cert-manager-webhook-6988db7859-fk5h5_operators(077cf6d9-b53b-48b7-bb18-da0b25eca027)
0s          Warning   BackOff               pod/cert-manager-webhook-6988db7859-fk5h5        Back-off restarting failed container cert-manager-webhook in pod cert-manager-webhook-6988db7859-fk5h5_operators(077cf6d9-b53b-48b7-bb18-da0b25eca027)
0s          Warning   BackOff               pod/cert-manager-webhook-6988db7859-fk5h5        Back-off restarting failed container cert-manager-webhook in pod cert-manager-webhook-6988db7859-fk5h5_operators(077cf6d9-b53b-48b7-bb18-da0b25eca027)
0s          Normal    Pulled                pod/cert-manager-webhook-6988db7859-fk5h5        Container image "quay.io/jetstack/cert-manager-webhook:v1.14.1" already present on machine
0s          Normal    Created               pod/cert-manager-webhook-6988db7859-fk5h5        Created container cert-manager-webhook
0s          Normal    Started               pod/cert-manager-webhook-6988db7859-fk5h5        Started container cert-manager-webhook
0s          Warning   BackOff               pod/cert-manager-webhook-6988db7859-fk5h5        Back-off restarting failed container cert-manager-webhook in pod cert-manager-webhook-6988db7859-fk5h5_operators(077cf6d9-b53b-48b7-bb18-da0b25eca027)
Error: The operation was canceled.

https://github.com/cert-manager/cert-manager-olm/actions/runs/7813016364/job/21311278187?pr=105

I also noticed that when I ran make bundle-test locally, and continued editing the files while the test was ongoing,
the computed catalog version changed between the running of an early make rule and a later make rule.
So I compute that version once when the makefile is parsed and use that as the default for all rules.

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Feb 7, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wallrj. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2024
Copy link
Member Author

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot
Copy link
Contributor

@wallrj: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wallrj wallrj merged commit 1109996 into cert-manager:master Feb 7, 2024
3 of 4 checks passed
@wallrj wallrj deleted the fix-bundle-test branch February 7, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants