[terra-folder-tree] Add the ability to expand/collapse folders #1915
Conversation
sycombs
force-pushed
the
folder-tree_expand-collapse
branch
from
e853812 to
411ae0a
Compare
|
The background color for non-selected elements does not appear to be correct in the lowlight theme |
There was a problem hiding this comment.
The overflow-wrap style still needs to be corrected. You wouldn't want to use anywhere.
There was a problem hiding this comment.
Not sure if you saw my reply on the last PR since it's been closed, but long strings without spaces don't wrap with break-word, or do we not expect consumers to have long strings without spaces?
There was a problem hiding this comment.
yes, they do. Break word will break anywhere when you run out of room.
| import FolderTree from '../../src/FolderTree'; | ||
| import FolderTreeItem from '../../src/subcomponents/FolderTreeItem'; |
There was a problem hiding this comment.
Can we import these from index.js? This way, the usage would be more in line with how a consumer would utilize it.
| onClick={onClick} | ||
| onChange={onClick} | ||
| aria-hidden // Hiding the radio button from assistive technology since they cannot be grouped correctly | ||
| tabIndex={-1} // Prevent tabbing to the button since it should not be read or acknowledged by assistive technology |
There was a problem hiding this comment.
This will allow the control to get focus when you click though. Is that what you want? Also, is this a composite widget? Will you actually have higher level logic controlling this similar to the WorklistDataGrid?
There was a problem hiding this comment.
We want the radio button to be clickable (per the UXPLATFORM-9679 AC) but we need to hide it from screenreaders so that they aren't reading radio buttons out of the tree hierarchy.
|
Merged so we can get a release out for expand/collapse, a follow-up Jira will be logged to address remaining comments. |
Summary
This PR adds the ability to expand and collapse folders so that users of
terra-folder-treecan show and hide items in the folder tree.Screenshots
Collapsed:
Expanded:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9680
Thank you for contributing to Terra.
@cerner/terra