Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): update development dependencies #1049

Merged
merged 2 commits into from
Nov 25, 2024
Merged

chore(deps-dev): update development dependencies #1049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b76defd
chore(deps-dev): update development dependencies
renovate[bot] Nov 25, 2024
aaf3517
Avoid adding empty trailing comments to oneof unions
haines Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
23.2.0
23.3.0
23 changes: 14 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "cerbos-sdk-javascript",
"private": true,
"packageManager": "pnpm@9.13.2",
"packageManager": "pnpm@9.14.2",
"engines": {
"node": "23.2.0",
"pnpm": "9.13.2"
"node": "23.3.0",
"pnpm": "9.14.2"
},
"scripts": {
"all:parallel": "concurrently --group --prefix=none",
Expand Down Expand Up @@ -52,25 +52,30 @@
},
"devDependencies": {
"@arethetypeswrong/cli": "0.17.0",
"@eslint/js": "9.14.0",
"@microsoft/api-documenter": "7.25.21",
"@microsoft/api-extractor": "7.47.11",
"@eslint/js": "9.15.0",
"@microsoft/api-documenter": "7.25.22",
"@microsoft/api-extractor": "7.47.12",
"@tsconfig/node18": "18.2.4",
"@tsconfig/strictest": "2.0.5",
"@types/eslint__js": "8.42.3",
"@types/node": "18.19.64",
"@vitest/eslint-plugin": "1.1.10",
"concurrently": "9.1.0",
"depcheck": "1.4.7",
"eslint": "9.14.0",
"eslint": "9.15.0",
"eslint-plugin-import": "2.31.0",
"eslint-plugin-react-hooks": "5.0.0",
"eslint-plugin-tsdoc": "0.3.0",
"prettier": "3.3.3",
"prettier-plugin-pkg": "0.18.1",
"ts-proto": "2.2.7",
"ts-proto": "2.3.0",
"tsx": "4.19.2",
"typescript": "5.6.3",
"typescript-eslint": "8.14.0"
"typescript-eslint": "8.15.0"
},
"pnpm": {
"patchedDependencies": {
"[email protected]": "patches/[email protected]"
}
}
}
22 changes: 22 additions & 0 deletions patches/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
diff --git a/build/src/main.js b/build/src/main.js
index 3e03249d11bae4b1ccc9000e0f4e41f1e4393f26..a6e519f26db63304ab4f29781261d2736d986382 100644
--- a/build/src/main.js
+++ b/build/src/main.js
@@ -851,7 +851,7 @@ function generateOneofProperty(ctx, messageDesc, oneofIndex, sourceInfo) {
let fieldComments = [];
(0, utils_1.maybeAddComment)(options, fieldInfo, fieldComments);
const combinedComments = fieldComments.join("\n");
- return (0, ts_poet_1.code) `| // \n ${combinedComments} { ${mbReadonly}$case: '${fieldName}', ${mbReadonly}${valueName}: ${typeName} }`;
+ return (0, ts_poet_1.code) `|${combinedComments ? " // " : ""}\n ${combinedComments} { ${mbReadonly}$case: '${fieldName}', ${mbReadonly}${valueName}: ${typeName} }`;
}));
const name = (0, case_1.maybeSnakeToCamel)(messageDesc.oneofDecl[oneofIndex].name, options);
return (0, ts_poet_1.joinCode)([...outerComments, (0, ts_poet_1.code) `${mbReadonly}${name}?:`, unionType, (0, ts_poet_1.code) `| ${(0, utils_1.nullOrUndefined)(options)},`], {
@@ -1155,7 +1155,7 @@ function generateDecode(ctx, fullName, messageDesc) {
}
chunks.push((0, ts_poet_1.code) `
const buf = reader.skip(tag & 7);
-
+
${unknownFieldsInitializerSnippet}
const list = message._unknownFields${maybeNonNullAssertion}[tag];

Loading