Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSI 0.3.0 1/4] vendor update #57

Merged
merged 2 commits into from
Aug 6, 2018
Merged

[CSI 0.3.0 1/4] vendor update #57

merged 2 commits into from
Aug 6, 2018

Conversation

gman0
Copy link
Contributor

@gman0 gman0 commented Jul 31, 2018

This PR starts a series of 4 patches in an effort of moving ceph-csi repo to CSI 0.3.0, part of #47

Updates Gopkg.toml and vendor code for CSI 0.3.0

Generated by dep version 0.5.0

$ dep ensure -update

/cc @rootfs @sbezverk

@@ -1,6 +1,6 @@
[[constraint]]
name = "github.com/container-storage-interface/spec"
version = "~0.2.0"
version = "~0.3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSI version 3.0 has dependency with protobuf version 1.1.0.
So we need to add protobuf dependency as well.

[[override]]
  name = "github.com/golang/protobuf"
  version = "1.1.0"

See: https://github.com/container-storage-interface/spec/blob/f7a67e709690807e0d6f7a6905c5900e338ca017/lib/go/Makefile#L61

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done! Gopkg.lock already contains protobuf in v1.1.0 so only Gopkg.toml was changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the Gopkg.lock.
But I think the explicit protobuf version is good.

Copy link
Contributor

@sngchlko sngchlko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rootfs rootfs merged commit 2fa82b4 into ceph:master Aug 6, 2018
@rootfs
Copy link
Member

rootfs commented Aug 6, 2018

thanks

@gman0 gman0 added this to the 0.3.0 milestone Aug 7, 2018
@gman0 gman0 deleted the v0.3.0-vendor branch August 8, 2018 08:26
wilmardo pushed a commit to wilmardo/ceph-csi that referenced this pull request Jul 29, 2019
[CSI 0.3.0 1/4] vendor update
agarwal-mudit pushed a commit to agarwal-mudit/ceph-csi that referenced this pull request Jul 1, 2021
sync devel with master branch
Madhu-1 pushed a commit to Madhu-1/ceph-csi that referenced this pull request Dec 14, 2021
BUG 2030745: rbd: added RBD features support for krbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants