-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSI 0.3.0 1/4] vendor update #57
Conversation
@@ -1,6 +1,6 @@ | |||
[[constraint]] | |||
name = "github.com/container-storage-interface/spec" | |||
version = "~0.2.0" | |||
version = "~0.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSI version 3.0 has dependency with protobuf version 1.1.0.
So we need to add protobuf dependency as well.
[[override]]
name = "github.com/golang/protobuf"
version = "1.1.0"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done! Gopkg.lock
already contains protobuf in v1.1.0 so only Gopkg.toml
was changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see the Gopkg.lock
.
But I think the explicit protobuf version is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
thanks |
[CSI 0.3.0 1/4] vendor update
sync devel with master branch
BUG 2030745: rbd: added RBD features support for krbd
This PR starts a series of 4 patches in an effort of moving ceph-csi repo to CSI 0.3.0, part of #47
Updates
Gopkg.toml
and vendor code for CSI 0.3.0Generated by
dep
version 0.5.0/cc @rootfs @sbezverk