deploy: set topology feature gate to false for rbd provisioner by default #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
approved these changes
Dec 8, 2020
agarwal-mudit
approved these changes
Dec 8, 2020
Madhu-1
added
component/deployment
|
/retest ci/centos/mini-e2e/k8s-1.18 |
|
/test ci/centos/mini-e2e/k8s-1.18 |
Not sure what could cause this: CI jobs did pass for other runs... 🤔 |
with csi-provisioner v2.x the topology based provisioning will not have any backward compatibility with older version of kubernetes, if the nodes are not labeled with topology keys, the pvc creation is going to get fail with error `accessibility requirements: no available topology found`, disabling the topology based provisioning by default, if user want to use it he can always enable it. Signed-off-by: Madhu Rajanna <[email protected]>
as we are testing the topology based provisioning in our E2E, we need to set topology=true in E2E. Signed-off-by: Madhu Rajanna <[email protected]>
external-provisioner is exposing a new argument to set the default fstype while starting the provisioner sidecar, if the fstype is not specified in the storageclass the default fstype will be applied for the pvc created from the storageclass. Signed-off-by: Madhu Rajanna <[email protected]>
ceph-csi-bot
force-pushed
the
fix-topo
branch
from
47faf88 to
0857e86
Compare
|
/retest ci/centos/mini-e2e-helm/k8s-1.19 |
Failed deploying Rook. Not sure what the error could be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with csi-provisioner v2.x the topology based provisioning will not have any backward compatibility with the older version of kubernetes if the nodes are not labeled with topology keys, the pvc creation is going to get fail with error
accessibility requirements: no available topology found, disabling the topology based provisioning by default if the user wants to use it he can always enable it.It also adds the default-fstype flag to the provisioner sidecar.
fixes: #1473
Signed-off-by: Madhu Rajanna [email protected]