Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Identity KeyStore pallet #824

Merged
merged 18 commits into from
Jun 23, 2022
Merged

Implement Identity KeyStore pallet #824

merged 18 commits into from
Jun 23, 2022

Conversation

cdamian
Copy link
Contributor

@cdamian cdamian commented Jun 1, 2022

No description provided.

@cdamian cdamian changed the title wip: WIP Implement Identity KeyStore pallet Jun 1, 2022
@cdamian cdamian force-pushed the 810-implement-identitykeystore-pallet branch from cf405bc to c1ecd61 Compare June 1, 2022 18:24
mikiquantum
mikiquantum suggested changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first stab at the chain and Rust! Let me know if the comments do not make sense 😄

NunoAlexandre
NunoAlexandre reviewed Jun 14, 2022
View reviewed changes
Copy link
Contributor

@NunoAlexandre NunoAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things that caught my eye in a short and superficial scan. I would like to go through it in detail later in the week

mikiquantum
mikiquantum reviewed Jun 21, 2022
View reviewed changes
Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdamian we are really close! This is looking good, just a few more comments.

@NunoAlexandre NunoAlexandre self-requested a review June 21, 2022 14:24
hieronx
hieronx reviewed Jun 21, 2022
View reviewed changes
Copy link
Contributor

@hieronx hieronx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @cdamian! Left a few small comments/questions.

@cdamian cdamian force-pushed the 810-implement-identitykeystore-pallet branch from 75ce9d0 to 5b243c3 Compare June 21, 2022 17:25
@cdamian cdamian marked this pull request as ready for review June 21, 2022 17:26
@cdamian
Copy link
Contributor Author

cdamian commented Jun 21, 2022

Benchmarks will be updated asap.

@mikiquantum mikiquantum self-requested a review June 21, 2022 18:47
mikiquantum
mikiquantum previously approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdamian Thank you! LGTM

@cdamian cdamian force-pushed the 810-implement-identitykeystore-pallet branch from 343403b to ca8159b Compare June 22, 2022 06:30
@cdamian
Copy link
Contributor Author

cdamian commented Jun 22, 2022

Benchmarks were updated.

NunoAlexandre
NunoAlexandre reviewed Jun 22, 2022
View reviewed changes
Copy link
Contributor

@NunoAlexandre NunoAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😃 minor nits and it's ready to go!

mikiquantum
mikiquantum approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

NunoAlexandre
NunoAlexandre approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@NunoAlexandre NunoAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work dude 🤟

@cdamian cdamian merged commit 733493f into parachain Jun 23, 2022
@cdamian cdamian deleted the 810-implement-identitykeystore-pallet branch June 23, 2022 10:29
@cdamian cdamian mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieronx hieronx hieronx left review comments

@NunoAlexandre NunoAlexandre NunoAlexandre approved these changes

@mikiquantum mikiquantum mikiquantum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdamian @hieronx @NunoAlexandre @mikiquantum