LPv2: Isolate gateway weights #1972
Conversation
| ); | ||
|
|
||
| let weight = match counter { | ||
| 0 => LP_DEFENSIVE_WEIGHT / 10, |
There was a problem hiding this comment.
We want to add just a bit if we fail even before starting to process the first message
There was a problem hiding this comment.
Should we maybe add a LP_MIN_WEIGHT or something?
There was a problem hiding this comment.
I would prefer hardcoding that as well, yes. An alternative would be a simple fn defensive_weight(counter).
There was a problem hiding this comment.
I didn't read it, and I had the auto-merge enabled. Tech-debt
| return (Err(e), weight.saturating_mul(count)); | ||
| } | ||
|
|
||
| if let Err(e) = Self::upsert_pending_entry(message_proof, &router_id, inbound_entry) { |
There was a problem hiding this comment.
My eyes are not bleeding anymore when looking at this, thank you <3
There was a problem hiding this comment.
BTW, liked that you moved the outbound processing impl into the MessageProcessor, now everything is quite unified 🙌🏻
| ); | ||
|
|
||
| let weight = match counter { | ||
| 0 => LP_DEFENSIVE_WEIGHT / 10, |
There was a problem hiding this comment.
I would prefer hardcoding that as well, yes. An alternative would be a simple fn defensive_weight(counter).
Description
Small PR to move the weight checks to
MessageProcessor.Like the fact that now only the
MessageProcessortrait implementation knows about weights