Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration-tests: Register routers during setup #1968

Conversation

cdamian
Copy link
Contributor

@cdamian cdamian commented Aug 15, 2024

No description provided.

@cdamian cdamian merged commit e59f1ed into feat/lp-v2-gateway-multi-router Aug 15, 2024
2 of 4 checks passed
@cdamian cdamian deleted the lp-gateway-multi-router-fix-integration-tests branch August 15, 2024 18:14
@cdamian
Copy link
Contributor Author

cdamian commented Aug 15, 2024

@lemunozm @wischli merged this directly since the change set wasn't as big as expected.

@cdamian
Copy link
Contributor Author

cdamian commented Aug 15, 2024

Also, didn't wanna end for another set of checks to be executed.

Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this changes!

cdamian added a commit that referenced this pull request Aug 16, 2024
* wip

* lp-gateway: Add router hash for inbound messages, extrinsic to set inbound routers, session ID storage

* lp-gateway: Add router hash for inbound messages, extrinsic to set inbound routers, session ID storage

* lp-gateway: Use router hashes for inbound, use session ID, update inbound message processing logic

* lp-gateway: Add and use InboundProcessingInfo

* lp-gateway: Unit tests WIP

* lp-gateway: Unit tests WIP 2

* docs: Improve comments

* lp-gateway: Move message processing logic to a new file

* lp-gateway: Merge inbound/outbound routers extrinsics into one, add logic for removing invalid session IDs on idle

* lp-gateway: Unit tests WIP

* lp-gateway: Add extrinsic for executing message recovery

* rebase: WIP

* Don't use domain when storing routers (#1962)

* lp-gateway: Unit tests WIP

* lp-gateway: Don't store routers under domain

* wip

* wip

* lp-gateway: Unit test WIP

* lp-gateway: Rename RouterSupport to RouterProvider, add separate entity that implements it

* lp-gateway: Add more asserts in unit tests

* lp-gateway: Attempt to execute message during recovery

* lp-gateway: Remove extra constraints from SessionId

* lp-gateway: Drop session ID invalidation (#1965)

* lp-gateway: Drop session ID invalidation

* lp-gateway: Add test for invalid router

* lp-gateway: Add more unit tests

* lp-gateway: Move InboundEntry logic to implementation

* lp-gateway: Use safe math

* lp-gateway: Add more unit tests

* checks: Fix clippy, taplo, formatting

* review: Remove mock-builder dep, rename LP encoding proof methods

* lp-gateway: Remove Default impls for RouterId and GatewayMessage

* lp-gateway: Allow empty list of routers

* lp-gateway: Drop InboundProcessingInfo

* lp-gateway: Rename LP encoding methods to get_proof and to_proof_message

* lp-gateway: Move outbound processing logic back to pallet

* review: Small fixes

* lp-gateway: Add comment for post voting dispatch error case

* lp-gatway: Drop session ID check in create_post_voting_entry

* lp: Remove unused import

* integration-tests: Register routers during setup (#1968)

* integration-tests: Set routers in all setup funcs and tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants