Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.13.0 #1898

Merged
merged 29 commits into from
Jul 11, 2024
Merged

Release v0.13.0 #1898

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
dd23213
chore: update deps to enable metadata hash check
wischli Jul 5, 2024
0a26688
chore: update srtool + add on-chain-release-build opts
wischli Jul 5, 2024
3da4e2e
chore: bump spec versions + cleanup migrations
wischli Jul 5, 2024
595b275
fmt: taplo
wischli Jul 5, 2024
d90644b
ci: fix srtool fmt
wischli Jul 5, 2024
4cb3180
ci: apply proper CLI
wischli Jul 5, 2024
3e02647
attempt2 to enable on-chain-release-build
wischli Jul 5, 2024
4f58c15
change srtool build for chevdor/strool-actions action
gpmayorga Jul 5, 2024
a882fd9
desperate attempts to get it working
wischli Jul 6, 2024
805273f
override workdir
gpmayorga Jul 8, 2024
7dd5f48
Try to set permissions wide open before running docker
gpmayorga Jul 8, 2024
559e568
add RUST_BACKTRACE
gpmayorga Jul 8, 2024
9d142f8
revert to our GHA manual process & add enhancements
gpmayorga Jul 8, 2024
b3a97bc
fix package name
gpmayorga Jul 8, 2024
8a259a4
Output information about srtool
gpmayorga Jul 8, 2024
99dce4b
Revert "desperate attempts to get it working"
wischli Jul 9, 2024
4601e21
fix: some scripts
wischli Jul 9, 2024
4ee87b6
fix bad colon on echo command
gpmayorga Jul 9, 2024
a649876
Fix missing colon and remove docker publish release
gpmayorga Jul 9, 2024
cfa9880
upload wasm to release
gpmayorga Jul 9, 2024
6472be0
fix issue with gchr tags
gpmayorga Jul 9, 2024
4a981c0
more semicolon issues
gpmayorga Jul 9, 2024
e52d367
Merge branch 'main' into release-v0.13.0
gpmayorga Jul 9, 2024
5edb9bf
unique name for delete untagged
gpmayorga Jul 9, 2024
d43b773
fix delete_untagged
gpmayorga Jul 9, 2024
ac4d669
move delete_untagged under workflows
gpmayorga Jul 9, 2024
acc6ff5
move delete untagged to manual runs
gpmayorga Jul 9, 2024
c4785b1
review bash syntax for wasm build
gpmayorga Jul 9, 2024
209167e
recover cache and limit sanity check build time
gpmayorga Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
desperate attempts to get it working
  • Loading branch information
@wischli
wischli committed Jul 6, 2024
commit a882fd96926383f1000e1bdda7a6a42e87c297ac
5 changes: 3 additions & 2 deletions runtime/altair/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ pallet-xcm-transactor = { workspace = true }
staging-parachain-info = { workspace = true }

[build-dependencies]
substrate-wasm-builder = { workspace = true }
substrate-wasm-builder = { workspace = true, optional = true }

[features]
default = ["std"]
Expand All @@ -157,6 +157,7 @@ std = [
"serde/std",
"log/std",
# Substrate related
"substrate-wasm-builder",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be "substrate-wasm-builder/std" to enable also std, if not, only the basic crate is added

"sp-api/std",
"sp-arithmetic/std",
"sp-runtime/std",
Expand Down Expand Up @@ -459,7 +460,7 @@ try-runtime = [
# generate the metadata hash and then a second time with the
# `RUNTIME_METADATA_HASH` environment variable set for the `CheckMetadataHash`
# extension.
metadata-hash = ["substrate-wasm-builder/metadata-hash"]
metadata-hash = ["substrate-wasm-builder?/metadata-hash"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the ??. is not your intention to always set the metadata-hash of substrate-wasm-builder each time you set metadata-hash


# A feature that should be enabled when the runtime should be build for on-chain
# deployment. This will disable stuff that shouldn't be part of the on-chain wasm
Expand Down
2 changes: 1 addition & 1 deletion runtime/altair/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2053,8 +2053,8 @@ pub type SignedExtra = (
frame_system::CheckNonce<Runtime>,
frame_system::CheckWeight<Runtime>,
pallet_transaction_payment::ChargeTransactionPayment<Runtime>,
frame_metadata_hash_extension::CheckMetadataHash<Runtime>,
runtime_common::transfer_filter::PreBalanceTransferExtension<Runtime>,
frame_metadata_hash_extension::CheckMetadataHash<Runtime>,
);

/// Unchecked extrinsic type as expected by this runtime.
Expand Down
5 changes: 3 additions & 2 deletions runtime/centrifuge/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ pallet-xcm-transactor = { workspace = true }
staging-parachain-info = { workspace = true }

[build-dependencies]
substrate-wasm-builder = { workspace = true }
substrate-wasm-builder = { workspace = true, optional = true }

[features]
default = ["std"]
Expand All @@ -166,6 +166,7 @@ std = [
"sp-transaction-pool/std",
"sp-version/std",
"sp-staking/std",
"substrate-wasm-builder",
"frame-support/std",
"frame-system/std",
"frame-system-rpc-runtime-api/std",
Expand Down Expand Up @@ -441,7 +442,7 @@ try-runtime = [
# generate the metadata hash and then a second time with the
# `RUNTIME_METADATA_HASH` environment variable set for the `CheckMetadataHash`
# extension.
metadata-hash = ["substrate-wasm-builder/metadata-hash"]
metadata-hash = ["substrate-wasm-builder?/metadata-hash"]

# A feature that should be enabled when the runtime should be build for on-chain
# deployment. This will disable stuff that shouldn't be part of the on-chain wasm
Expand Down
2 changes: 1 addition & 1 deletion runtime/centrifuge/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2064,8 +2064,8 @@ pub type SignedExtra = (
frame_system::CheckNonce<Runtime>,
frame_system::CheckWeight<Runtime>,
pallet_transaction_payment::ChargeTransactionPayment<Runtime>,
frame_metadata_hash_extension::CheckMetadataHash<Runtime>,
runtime_common::transfer_filter::PreBalanceTransferExtension<Runtime>,
frame_metadata_hash_extension::CheckMetadataHash<Runtime>,
);

/// Unchecked extrinsic type as expected by this runtime.
Expand Down
5 changes: 3 additions & 2 deletions runtime/development/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ pallet-xcm-transactor = { workspace = true }
staging-parachain-info = { workspace = true }

[build-dependencies]
substrate-wasm-builder = { workspace = true }
substrate-wasm-builder = { workspace = true, optional = true }

[features]
default = ["std"]
Expand All @@ -173,6 +173,7 @@ std = [
"sp-transaction-pool/std",
"sp-version/std",
"sp-staking/std",
"substrate-wasm-builder",
"frame-support/std",
"frame-system/std",
"frame-system-rpc-runtime-api/std",
Expand Down Expand Up @@ -463,7 +464,7 @@ try-runtime = [
# generate the metadata hash and then a second time with the
# `RUNTIME_METADATA_HASH` environment variable set for the `CheckMetadataHash`
# extension.
metadata-hash = ["substrate-wasm-builder/metadata-hash"]
metadata-hash = ["substrate-wasm-builder?/metadata-hash"]

# A feature that should be enabled when the runtime should be build for on-chain
# deployment. This will disable stuff that shouldn't be part of the on-chain wasm
Expand Down
2 changes: 1 addition & 1 deletion runtime/development/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2154,8 +2154,8 @@ pub type SignedExtra = (
frame_system::CheckNonce<Runtime>,
frame_system::CheckWeight<Runtime>,
pallet_transaction_payment::ChargeTransactionPayment<Runtime>,
frame_metadata_hash_extension::CheckMetadataHash<Runtime>,
runtime_common::transfer_filter::PreBalanceTransferExtension<Runtime>,
frame_metadata_hash_extension::CheckMetadataHash<Runtime>,
);
/// Unchecked extrinsic type as expected by this runtime.
pub type UncheckedExtrinsic =
Expand Down
2 changes: 1 addition & 1 deletion runtime/integration-tests/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,8 @@ pub trait Runtime:
frame_system::CheckNonce<Self>,
frame_system::CheckWeight<Self>,
pallet_transaction_payment::ChargeTransactionPayment<Self>,
frame_metadata_hash_extension::CheckMetadataHash<Self>,
runtime_common::transfer_filter::PreBalanceTransferExtension<Self>,
frame_metadata_hash_extension::CheckMetadataHash<Self>,
),
>,
>;
Expand Down
2 changes: 1 addition & 1 deletion runtime/integration-tests/src/env.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,8 @@ pub mod utils {
frame_system::CheckNonce::<T>::from(nonce),
frame_system::CheckWeight::<T>::new(),
pallet_transaction_payment::ChargeTransactionPayment::<T>::from(0),
frame_metadata_hash_extension::CheckMetadataHash::<T>::new(false),
runtime_common::transfer_filter::PreBalanceTransferExtension::<T>::new(),
frame_metadata_hash_extension::CheckMetadataHash::<T>::new(false),
);

let raw_payload = SignedPayload::new(runtime_call.clone(), signed_extra.clone()).unwrap();
Expand Down
Loading