Remove custom implementation for MaxEncodingLen
#1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
Q1-easy
cdamian
previously approved these changes
Apr 8, 2024
wischli
previously approved these changes
Apr 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1800 +/- ##
==========================================
+ Coverage 48.46% 48.53% +0.07%
==========================================
Files 168 167 -1
Lines 13332 13311 -21
==========================================
Hits 6461 6461
+ Misses 6871 6850 -21 ☔ View full report in Codecov by Sentry. |
lemunozm
dismissed stale reviews from wischli and cdamian
The base branch was changed.
lemunozm
force-pushed
the
ref/remove-custom-max-encoding
branch
from
332cb6b to
2b833f3
Compare
auto-merge was automatically disabled
April 15, 2024 11:30
Pull request was converted to draft
lemunozm
force-pushed
the
ref/remove-custom-max-encoding
branch
from
2b833f3 to
d2a4bfe
Compare
lemunozm
force-pushed
the
ref/remove-custom-max-encoding
branch
from
1697d32 to
1d51721
Compare
|
Can any of you re-approve this? @cdamian @wischli @mustermeiszer 🙏🏻 |
wischli
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had some
MaxEncodingLentraits implemented manually for some types. Sincepolkadot-v1.1.0, it seems we can get rid of our custom implementation and let Rust do it for us.NOTE: Blocked until
v1.1.0