Add a readiness check to the Docker container #1656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpmayorga
added
Q1-easy
gpmayorga
force-pushed
the
docker-readiness-fullnode
branch
from
cd033e9 to
6338404
Compare
wischli
reviewed
Dec 22, 2023
Comment on lines
+36
to
+40
| # - name: DockerHub Registry Login | ||
| # uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d | ||
| # with: | ||
| # username: ${{ secrets.DOCKER_HUB_USERNAME }} | ||
| # password: ${{ secrets.DOCKER_HUB_TOKEN }} |
There was a problem hiding this comment.
Can we entirely remove this? We shouldn't commit commented code unless not absolutely necessary. If so, please add a top comment explaining why this is commented out and when it should be used.
|
Doing some research I found a better way to do healthchecks without needing to compromise the Docker image for the parachain: Closing this and opening a new PR with some of the enhancements of this PR without the readiness check |
gpmayorga
added a commit
that referenced
this pull request
Dec 26, 2023
# Description This PR: - Sets some additional RFC standard LABELS to our Docker container - Upload the container to both GitHub and DockerHub registries (PRs do not upload to DH) - Minor Dockerfile efficiencies. It's a follow up from #1656
gpmayorga
added a commit
that referenced
this pull request
Jan 16, 2024
* Add a readiness check to the Docker container * missing path change for centrifuge binary * push docker to GH registry on PRs to test image * more standard paths for the binaries * log into ghcr * Add standardized OCI labels * push to both registries * fix registry permissions * comply with RFC3339 standard date format * Minor Docker enhancements # Description This PR: - Sets some additional RFC standard LABELS to our Docker container - Upload the container to both GitHub and DockerHub registries (PRs do not upload to DH) - Minor Dockerfile efficiencies. It's a follow up from #1656 * cleanup from old PR * Update build-docker.yml with kf info
wischli
pushed a commit
that referenced
this pull request
Jan 29, 2024
* Add a readiness check to the Docker container * missing path change for centrifuge binary * push docker to GH registry on PRs to test image * more standard paths for the binaries * log into ghcr * Add standardized OCI labels * push to both registries * fix registry permissions * comply with RFC3339 standard date format * Minor Docker enhancements # Description This PR: - Sets some additional RFC standard LABELS to our Docker container - Upload the container to both GitHub and DockerHub registries (PRs do not upload to DH) - Minor Dockerfile efficiencies. It's a follow up from #1656 * cleanup from old PR * Update build-docker.yml with kf info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a pre-requisite to be able to run our fullnode/archive infrastructure as an auto-scalable cluster. In order for a proxy or a load balancer to know if a fullnode is ready to accept traffic it needs to check a bit more than "is port 9933 open?".
This PR:
Reviewers: if you think about something more sophisticated or consider "isSyncheched and has peers" insuficient please add to the script. The important question it needs to answer is "Am I ready to recieve RPC and WS traffic?"
Extras on this PR: