permissions: Add PODReadAccess permission #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieronx
reviewed
Feb 24, 2023
cdamian
force-pushed
the
add-pod-read-access-permission
branch
from
4b52f1f to
a12ac30
Compare
hieronx
reviewed
Feb 24, 2023
| @@ -289,6 +295,7 @@ where | |||
| } | |||
| PoolRole::LoanAdmin => Ok(self.pool_admin.insert(PoolAdminRoles::RISK_ADMIN)), | |||
There was a problem hiding this comment.
This is unrelated to this PR, but the naming seems a bit off here, not all pool roles are pool admin roles. I wonder if we should change self.pool_admin to self.pool and PoolAdminRoles to just PoolRoles. What do you think?
There was a problem hiding this comment.
Sounds sane to me. I would be more pro having an additional struct like PoolAdminRoles and PoolRoles but this would mean we need to write a migration. So lets keep it simple.
cdamian
force-pushed
the
add-pod-read-access-permission
branch
from
a12ac30 to
032ffb2
Compare
cdamian
force-pushed
the
add-pod-read-access-permission
branch
from
032ffb2 to
2521570
Compare
mustermeiszer
approved these changes
Feb 24, 2023
| @@ -289,6 +295,7 @@ where | |||
| } | |||
| PoolRole::LoanAdmin => Ok(self.pool_admin.insert(PoolAdminRoles::RISK_ADMIN)), | |||
There was a problem hiding this comment.
Sounds sane to me. I would be more pro having an additional struct like PoolAdminRoles and PoolRoles but this would mean we need to write a migration. So lets keep it simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
PODReadAccesspermission.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
mainbranch