Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Review GHA pipeline #2620

Merged
merged 21 commits into from
Feb 11, 2025
Merged

ci: Review GHA pipeline #2620

merged 21 commits into from
Feb 11, 2025

Conversation

gpmayorga
Copy link
Collaborator

@gpmayorga gpmayorga commented Feb 8, 2025

Description

This pull request...

  • Upgrades all available external GH Actions to newer versions.
  • Upgrades the node version of Gcloud functions from v18 to v20 as it deprecates in April
  • Configures dependabot to catch new GHA version packages monthly (needs activation in setitngs of the repository)
  • Fixes a bug where production deployments might fetch from the wrong artifacts
  • Fixes small typo, linting and syntax issues in the workflow files
  • Removes catalyst deployment
  • Removes deployment of functions for environments: fast-forward (main) & development.
  • Add new OWNERS to make sure we have at least 3 as at least 2 are needed to approve a PR (the one creating the change and a reviewer)
  • Changes how prod is deployed which now will:
    • Fetch the artifacts form the relese assets
    • Allow to specify a tag that has been released in the past to roll back prod.
Screenshot 2025-02-10 at 20 14 49

Impact

Lots of small changes that should not change the pipline behavior but critical changes were made to:

  • Prod deployment, needs testing to make sure it works as intended (needs to be merged first)
  • Function deployment masked under NEVER_USED which was causing an actual NEVER_USED function to be deployed in Google repeatedly, causing a lot of worflows to fail (look at main branch commits mostly all red)

Pending testing

  • Test the release workflow for production (needs merging to main first)
  • Test the pinning and onboarding functions (upgraded to node 20)

Copy link

github-actions bot commented Feb 8, 2025

PR deployed in Google Cloud
URL: https://pr2620-app-ff-production.k-f.dev
PINNING_URL: https://europe-central2-peak-vista-185616.cloudfunctions.net/pinning-api-pr2620
ONBOARDING_URL: https://europe-central2-peak-vista-185616.cloudfunctions.net/onboarding-api-pr2620
Commit #: 4b185ff

Copy link

github-actions bot commented Feb 8, 2025

PR deployed in Google Cloud
URL: https://app-pr2620.k-f.dev
PINNING_URL: https://europe-central2-peak-vista-185616.cloudfunctions.net/pinning-api-pr2620
ONBOARDING_URL: https://europe-central2-peak-vista-185616.cloudfunctions.net/onboarding-api-pr2620
Commit #: 4b185ff

.github/workflows/e2e.yml Show resolved Hide resolved
.github/workflows/manual-deploys.yml Show resolved Hide resolved
.github/workflows/prod-deploy.yml Outdated Show resolved Hide resolved
@gpmayorga gpmayorga enabled auto-merge (squash) February 11, 2025 15:01
@gpmayorga gpmayorga merged commit e859dd0 into main Feb 11, 2025
22 checks passed
@gpmayorga gpmayorga deleted the gha-review branch February 11, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants