-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centrifuge App: transfer CFG to EVM address #1720
Conversation
…vm-transfer-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other comment @sophialittlejohn: the Centrifuge token should only show up when you are connected to the Centrifuge
network, not any other EVM network
|
03770b7
to
0896b56
Compare
@sophialittlejohn can you also change the denomination of CFG in the Market value column to USD instead of USDT? Also maybe mismatching with design, but tiny change: can you change |
Ran into 1 bug: if you try to transfer the max amount of CFG, the transfer will fail, because then you cannot pay the transaction fees. So the max amount should actually be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran into 1 bug: if you try to transfer the max amount of CFG, the transfer will fail, because then you cannot pay the transaction fees. So the max amount should actually be CFG balance - estimated transaction fee.
Confirmed this is fixed now, nice work!
PR deployed in Google Cloud |
Description
This pull request...
Still missing:
#1710
#1669
Approvals
Screenshots
Impact