Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centrifuge App: transfer CFG to EVM address #1720

Merged
merged 36 commits into from
Dec 8, 2023

Conversation

sophialittlejohn
Copy link
Collaborator

@sophialittlejohn sophialittlejohn commented Nov 30, 2023

Description

This pull request...

  • implements drawer for sending and receiving CFG (click on portfolio --> Holdings --> CFG row or prime --> aave --> Holdings --> CFG row)
  • adds CFG price chart in drawer, accessible from both prime and portfolio pages
  • changes the inputs background color to white and primary button color to blue as a first step towards new inputs
  • improves the x-axis tick styles for all charts

Still missing:

  • transaction table in drawer (requires subql work --> follow up #1726)

#1710
#1669

Approvals

  • Dev
  • Dev
  • Designer
  • Product

Screenshots

Impact

@sophialittlejohn sophialittlejohn marked this pull request as draft December 1, 2023 00:00
@sophialittlejohn sophialittlejohn marked this pull request as ready for review December 5, 2023 21:00
Copy link
Contributor

@hieronx hieronx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other comment @sophialittlejohn: the Centrifuge token should only show up when you are connected to the Centrifuge network, not any other EVM network

@annamehr
Copy link
Contributor

annamehr commented Dec 6, 2023

@sophialittlejohn

  • One minor comment to change the token name to CFG instead of Centrifuge. Similar to what's been shared in the design.
  • Can you add the same tooltip that you added to the price in the slide over to the price in the holdings section as well? It's a legal requirement.

@sophialittlejohn sophialittlejohn force-pushed the cent-app/cfg-evm-transfer-support branch from 03770b7 to 0896b56 Compare December 6, 2023 17:48
@hieronx
Copy link
Contributor

hieronx commented Dec 6, 2023

@sophialittlejohn can you also change the denomination of CFG in the Market value column to USD instead of USDT?

Also maybe mismatching with design, but tiny change: can you change CFG Price to CFG price (no capital P), Ethereum Address to Ethereum address and Centrifuge native address?

@hieronx
Copy link
Contributor

hieronx commented Dec 6, 2023

Ran into 1 bug: if you try to transfer the max amount of CFG, the transfer will fail, because then you cannot pay the transaction fees. So the max amount should actually be CFG balance - estimated transaction fee.

Copy link
Contributor

@hieronx hieronx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into 1 bug: if you try to transfer the max amount of CFG, the transfer will fail, because then you cannot pay the transaction fees. So the max amount should actually be CFG balance - estimated transaction fee.

Confirmed this is fixed now, nice work!

Copy link

github-actions bot commented Dec 8, 2023

PR deployed in Google Cloud
URL: https://app-pr1720.k-f.dev
Commit #: 14b10c7
To access the functions directly check the corresponding deploy Action

@sophialittlejohn sophialittlejohn merged commit 987848e into main Dec 8, 2023
8 checks passed
@sophialittlejohn sophialittlejohn deleted the cent-app/cfg-evm-transfer-support branch December 8, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants