Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cta tokens #96

Merged
merged 5 commits into from
Dec 10, 2021
Merged

Feature/cta tokens #96

merged 5 commits into from
Dec 10, 2021

Conversation

andij
Copy link
Contributor

@andij andij commented Dec 7, 2021 •
edited
Loading

  • initial use of component tokens for cta
  • refactor cta CSS to use Logical Properties
  • introduce colour palette
  • swap placeholder url in cta Storybook to be #!
  • use focus-visible for the focus styles
    • this will remove the focus outline on the cta when interacting using the mouse/touch, but will show when tabbed to using the keyboard.

@andij andij merged commit 9a170ee into main Dec 10, 2021
@andij andij deleted the feature/cta-tokens branch December 10, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MekalaNagarajan-Centrica MekalaNagarajan-Centrica MekalaNagarajan-Centrica approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andij @MekalaNagarajan-Centrica