Feature/cypress browserstack #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PraveenAsokan
commented
Jan 26, 2022
•
PraveenAsokan
commented
- Add BrowserStack library to dependencies
- Set up browserstack.json file
- Add script for cypress-browserstack in package.json
- Add unwanted run time folders to gitignore
- Few script maintenance
This was referenced Feb 4, 2022
| @@ -8,27 +8,27 @@ Feature: muon inputter component | |||
|
|
|||
| Examples: | |||
| |component |type | | |||
| |muon-inputter |standard | | |||
| |muon-inputter |text | | |||
There was a problem hiding this comment.
type attribute values are not supported now.
There was a problem hiding this comment.
It's just for the BDD to launch the correct URL for the test. We are validating inputtype attribute separately in the script
cypress/support/commands.js
Outdated
Comment on lines
18
to
19
| cy.clearInput(); | ||
| cy.enterValue(value); |
There was a problem hiding this comment.
remove these from here and have them in each test for better understanding of test.
| Cypress.on('uncaught:exception', (err, runnable) => { | ||
| // returning false here prevents Cypress from | ||
| // failing the test | ||
| return false; |
There was a problem hiding this comment.
What happens when there is an exception? Does the test report as failure or skips?
There was a problem hiding this comment.
This is to avoid some unwanted exceptions thrown during the run. It won't skip the failed tests. It captures the error and fails the test as excepted.
MekalaNagarajan-Centrica
approved these changes
Feb 14, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.