Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Publish initial performance numbers #436

Merged
merged 13 commits into from
Feb 28, 2019
Merged

Publish initial performance numbers #436

merged 13 commits into from
Feb 28, 2019

Conversation

flands
Copy link
Contributor

@flands flands commented Feb 27, 2019

Addresses #276

@flands flands added this to the 0.2.0 milestone Feb 27, 2019
@flands flands self-assigned this Feb 27, 2019
@flands flands requested review from sjkaris and pjanotti February 27, 2019 03:59
@flands flands requested a review from a team as a code owner February 27, 2019 03:59
songy23
songy23 reviewed Feb 27, 2019
View reviewed changes
@flands
Added OS
263ca17
@flands
Merge branch 'perf' of github.com:Omnition/opencensus-service into perf
89d5e06 
* 'perf' of github.com:Omnition/opencensus-service:
  Formatting tweaks
  Add Unified factory interfaces (#428)
  Add the source name to the receiver interface. (#435)
  Remove unused failure from the return values. (#434)
  Update collector code to use [Trace|Metrics]Data. (#431)
@codecov
Copy link

codecov bot commented Feb 27, 2019 •
edited
Loading

Codecov Report

Merging #436 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   63.21%   63.27%   +0.05%     
==========================================
  Files          42       42              
  Lines        3379     3379              
==========================================
+ Hits         2136     2138       +2     
+ Misses       1090     1089       -1     
+ Partials      153      152       -1
Impacted Files Coverage Δ
...al/collector/processor/nodebatcher/node_batcher.go 79.09% <0%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4c33d...cb66453. Read the comment docs.

@flands flands closed this Feb 27, 2019
@flands flands reopened this Feb 27, 2019
songy23
songy23 approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please leave a TODO or file a new issue for adding numbers on receiving OpenCensus span protos.

@flands
Copy link
Contributor Author

flands commented Feb 28, 2019

Filed #438

bogdandrutu
bogdandrutu reviewed Feb 28, 2019
View reviewed changes
Makefile
@@ -48,7 +48,7 @@ lint:

.PHONY: install-tools
install-tools:
go get -u golang.org/x/lint/golint
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -u flag instructs get to use the network to update the named packages and their dependencies. By default, get uses the network to check out missing packages but does not use it to look for updates to existing packages.

I don't think removing this is necessary good. Maybe we should file an issue to restore this after lint fixes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the idea is that this is a temporary workaround.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#439

@flands flands merged commit 1ce867d into census-instrumentation:master Feb 28, 2019
@flands flands deleted the perf branch February 28, 2019 01:20
@bogdandrutu
Copy link

Hi all,

Can we get a pprof sample while we run the loadtests. I am very interested to see where we have the performance problems - if possible get cpu/block/mutex (all would be great).

@flands
Copy link
Contributor Author

flands commented Feb 28, 2019

We did not have pprof initially, but when we run the next set of tests we will.

pjanotti pushed a commit to pjanotti/opencensus-service that referenced this pull request Jun 12, 2019
Use go 1.12.5 and update go lint
bfda1da 
Upgrading go version and fixing census-instrumentation#436
fivesheep pushed a commit to fivesheep/opencensus-service that referenced this pull request Jun 12, 2019
@flands
Publish initial performance numbers (census-instrumentation#436)
e9d0811 
* Add initial performance numbers
pjanotti pushed a commit that referenced this pull request Jun 14, 2019
Update go and lint (#570)
ae3b7fe 
* Use go 1.12.5 and update go lint

Upgrading go version and fixing #436

* Update .travis.yml and CONTRIBUTING.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bogdandrutu bogdandrutu bogdandrutu left review comments

@yurishkuro yurishkuro yurishkuro left review comments

@pjanotti pjanotti pjanotti approved these changes

@songy23 songy23 songy23 approved these changes

@sjkaris sjkaris Awaiting requested review from sjkaris

Assignees

@flands flands

Labels
cla: yes
Projects
None yet
Milestone
0.1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@flands @bogdandrutu @yurishkuro @pjanotti @songy23 @googlebot