PoC: Move Generated Typescript Web3 Core Contracts to their own package #9912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what would be really great is if the types for using with ethers were also published |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the typescript files for the core contracts are generated in the contractkit package using a script in the protocol package (as well as using .sol files). This creates a bind between protocol package and the contractkit package.
In order to to achieve separation I propose creating a third package which would consist solely of the generated js and type files for the contracts.
Other changes
n/a
Tested
not yet, testing would just be confirming it fits our needs
Related issues
compatibility
we could add re exports to contract kit to make this not breaking if we want
Documentation