Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #8764

Merged
merged 7 commits into from
Oct 12, 2021
Merged

Code cleanup #8764

merged 7 commits into from
Oct 12, 2021

Conversation

alecps
Copy link
Contributor

@alecps alecps commented Oct 10, 2021

Description

Mostly cosmetic changes from code review.

Tested

Should be re-tested e2e before deployment.

Backwards compatibility

yes

Documentation

None

@alecps alecps requested a review from barbaraliau as a code owner October 10, 2021 11:45
@alecps alecps requested review from a team, codyborn and eelanagaraj and removed request for a team and barbaraliau October 10, 2021 11:45
Copy link
Contributor

@eelanagaraj eelanagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! added a few questions/comments :)

packages/attestation-service/src/lookup/vonage.ts Outdated Show resolved Hide resolved
packages/attestation-service/README.md Outdated Show resolved Hide resolved
packages/sdk/utils/src/verifiableCredential.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@codyborn codyborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants