-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup #8764
Merged
Merged
Code cleanup #8764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecps
requested review from
a team,
codyborn and
eelanagaraj
and removed request for
a team and
barbaraliau
October 10, 2021 11:45
alecps
commented
Oct 11, 2021
packages/attestation-service/src/requestHandlers/verifiable_credential.ts
Show resolved
Hide resolved
eelanagaraj
reviewed
Oct 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! added a few questions/comments :)
yorhodes
reviewed
Oct 11, 2021
codyborn
approved these changes
Oct 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This was referenced Oct 15, 2021
This was referenced Oct 23, 2021
This was referenced Apr 21, 2022
This was referenced May 26, 2022
This was referenced Aug 5, 2022
This was referenced Oct 6, 2022
This was referenced Apr 24, 2023
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly cosmetic changes from code review.
Tested
Should be re-tested e2e before deployment.
Backwards compatibility
yes
Documentation
None