Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend hosted node GCP documentation #7347

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Conversation

AlexBHarley
Copy link
Contributor

@AlexBHarley AlexBHarley commented Mar 5, 2021

Description

GCP won't display public images, so you need to know the name before launching, which means you need to go via the API or gcloud.

Copy link
Contributor

@eelanagaraj eelanagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one thing -- it seems like it's not linked properly from the external page here https://docs.celo.org/getting-started/mainnet/running-a-full-node-in-mainnet, so it'll direct users to the MD doc in github, maybe we need to add this page to the summary/make sure it is part of gitbook?

Edit: actually looks like the page is part of gitbook here but we need to fix the linking on the page above

@AlexBHarley AlexBHarley added the automerge Have PR merge automatically when checks pass label Mar 22, 2021
@mergify mergify bot merged commit 9b43d07 into master Mar 22, 2021
@mergify mergify bot deleted the alexbharley/amend-hosted-node-docs branch March 22, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants