[Wallet] <BigNumber>.toString() almost never return exponential notation #6212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i1skn
requested review from
cmcewen,
jeanregisser and
jmrossy
as code owners
jeanregisser
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is quite a few usages of
<BigNumber>.toString()around the codebase, which potentially can return exponential notation, which AFAIK not needed anywhere in the app. This change would make<BigNumber>.toString()almost identical to<BigNumber>.toFixed(), which always returns fixed notation.For reference: https://mikemcl.github.io/bignumber.js/#exponential-at
Also, removed unused param in
createStandbyTxfunction.Related issues
Backwards compatibility
Yes