Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[attestation-proxy] add firebase-admin as a dependency #5692

Merged
merged 3 commits into from
Nov 5, 2020
Merged

[attestation-proxy] add firebase-admin as a dependency #5692

merged 3 commits into from
Nov 5, 2020

Conversation

i1skn
Copy link
Contributor

@i1skn i1skn commented Nov 3, 2020

Description

Add firebase-admin as a dependency to attestation-proxy, without which yarn deploy would result into broken functions.

Tested

Deployed successfully to celo-mobile-mainnet firebase project.

Backwards compatibility

Yes

@i1skn i1skn requested a review from jmrossy as a code owner November 3, 2020 20:35
@i1skn i1skn requested review from aslawson and etuleu November 4, 2020 12:11
@aslawson aslawson added the automerge Have PR merge automatically when checks pass label Nov 5, 2020
@mergify mergify bot merged commit a03ba79 into master Nov 5, 2020
@mergify mergify bot deleted the i1skn/fix-attestation-proxy-deploy branch November 5, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslawson aslawson aslawson approved these changes

@jmrossy jmrossy Awaiting requested review from jmrossy

@etuleu etuleu Awaiting requested review from etuleu

Assignees
No one assigned
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i1skn @aslawson