[Wallet] Fix account timeout issue during verification #5656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i1skn
force-pushed
the
i1skn/fix-unlock-timeout
branch
from
8aa2054 to
1f0318a
Compare
i1skn
force-pushed
the
i1skn/fix-unlock-timeout
branch
from
1f0318a to
a063e79
Compare
i1skn
changed the title
jeanregisser
reviewed
Nov 4, 2020
Comment on lines
+95
to
+99
| // Lock and ask user for a PIN because we | ||
| // want to reset timeout for unlocked account | ||
| clearPasswordCaches() | ||
| yield call(unlockAccount, account, true) | ||
|
|
There was a problem hiding this comment.
This causes the user to be asked for their PIN when starting verification, right?
| @@ -200,7 +200,7 @@ export const reducer = ( | |||
| case Actions.COMPLETE_ATTESTATION_CODE: | |||
| return { | |||
| ...state, | |||
| ...completeCodeReducer(state, state.numCompleteAttestations + 1), | |||
| numCompleteAttestations: state.numCompleteAttestations + 1, | |||
There was a problem hiding this comment.
Why is this change needed?
There was a problem hiding this comment.
this is needed because completeCodeReducer should be used only for the case when we set completed codes initially. We can not use it here, because on this line
attestationCodes[i] undefined yet acceptedAttestationCodes[i], which will be defined after this reducer is finishes.
|
@jeanregisser I have addressed the feedback! PTAL |
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2020
### Description #5656 has introduced mandatory enter of PIN code while onboarding flow to prevent account unlock timeout issue. This PR would disable it specifically to the initial onboarding (we hope that 10 minutes since user sets the PIN would be enough to finish onboarding initially) and keep it if user comes back to verification later. ### Caveat The only one I see is when user goes to verification from Home screen, enters PIN, press Start/Resume, press back, user again needs to enter a PIN code. Not sure how often this is happening and to which extent it would ruin the UX. ### Tested Initial onboarding with verification and return to verification flow later. ### Backwards compatibility Yes
|
@jeanregisser Verified task using Test flight build v1.4.0 (28) and Android play store (internal build) v1.4.0 (1004294317) and found that user is able to complete phone number verification flow with out facing any verification failed pop up. Verified on : iPhone XR (13.2.2) and Google Pixel XL (8.1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other changes
Fix issue, when last confirmed attestation code is become empty after it is confirmed.
Tested
Verification flow done
Related issues
Backwards compatibility
Yes