Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Allow skipping verification if ODIS is down #5438

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

gnardini
Copy link
Contributor

Description

ODIS is down in Alfajores right now and when doing the onboarding the app is stuck on the verification screen because there is a permanent loading screen and the skip verification modal doesn't show up. I copied the modal so that it's shown even if the screen is loading.

Note: This is blocking the wallet e2e tests.

Tested

Manually and added a unit test.

Related issues

Copy link
Contributor

@annakaz annakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this modal always going to be shown, or just when ODIS is down? Also has the e2e Android test been updated to use this skip modal?

@gnardini
Copy link
Contributor Author

@annakaz

Is this modal always going to be shown, or just when ODIS is down? Also has the e2e Android test been updated to use this skip modal?

The modal is now duplicated, once for the loading screen and once for the normal screen. So the modal should show up no matter if the loading screen is showing or not. It pops up when someone taps on the Skip button on the header.

The e2e tests should have no difference, they tap on the skip button and then press on the confirm button on the modal.

Copy link
Contributor

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gnardini gnardini added the automerge Have PR merge automatically when checks pass label Oct 20, 2020
@mergify mergify bot merged commit 67b40d1 into master Oct 20, 2020
@mergify mergify bot deleted the fix-skip-verification branch October 20, 2020 15:09
gnardini added a commit that referenced this pull request Oct 21, 2020
### Description

ODIS is down in Alfajores right now and when doing the onboarding the app is stuck on the verification screen because there is a permanent loading screen and the skip verification modal doesn't show up. I copied the modal so that it's shown even if the screen is loading.

Note: This is blocking the wallet e2e tests.

### Tested

Manually and added a unit test.

### Related issues

- Fixes #5437
@Lss-Ankit
Copy link

Hi @gnardini can you please provide more details to verify this task.
And AFAIK the latest builds are Android play store internal build v1.3.0(1004294316) & Test Flight build v1.3.0(27) connected with Mainet,
So, can you please provide a build details which connect to Alfajore network to verify this task if we need to verify this task on Alfajore network.

@gnardini
Copy link
Contributor Author

Hi @Lss-Ankit
It is a difficult task to verify. The way I could find is to test is the following:

  • Restore an account that has funds. The screen after putting in the Account Key is the verification screen. If you try to press the "Skip" button while the screen is still loading, the confirmation modal should pop up.

The screen should look like this:

Screen Shot 2020-10-26 at 10 31 53

This is the modal that should pop up when pressing the "Skip" button:
Screen Shot 2020-10-26 at 10 33 59

The problem used to be that the popup didn't show up when loading. Now it should show up even if the screen is still loading.

@Lss-Ankit
Copy link

Hi @gnardini Verified issue on latest Test flight build v1.3.0(27) and Android play store internal build v1.3.0(1004294316) and observed that user is able to tap on Skip button when loading indicator is shown on Confirm screen.

Verified devices:

  • Google pixel Xl (8.1) , iPhone SE 2 (14.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow skipping verification if ODIS is down
4 participants