-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wallet] Allow skipping verification if ODIS is down #5438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this modal always going to be shown, or just when ODIS is down? Also has the e2e Android test been updated to use this skip modal?
The modal is now duplicated, once for the loading screen and once for the normal screen. So the modal should show up no matter if the loading screen is showing or not. It pops up when someone taps on the Skip button on the header. The e2e tests should have no difference, they tap on the skip button and then press on the confirm button on the modal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
### Description ODIS is down in Alfajores right now and when doing the onboarding the app is stuck on the verification screen because there is a permanent loading screen and the skip verification modal doesn't show up. I copied the modal so that it's shown even if the screen is loading. Note: This is blocking the wallet e2e tests. ### Tested Manually and added a unit test. ### Related issues - Fixes #5437
Hi @gnardini can you please provide more details to verify this task. |
Hi @Lss-Ankit
The screen should look like this: This is the modal that should pop up when pressing the "Skip" button: The problem used to be that the popup didn't show up when loading. Now it should show up even if the screen is still loading. |
Hi @gnardini Verified issue on latest Test flight build v1.3.0(27) and Android play store internal build v1.3.0(1004294316) and observed that user is able to tap on Skip button when loading indicator is shown on Confirm screen. Verified devices:
|
Description
ODIS is down in Alfajores right now and when doing the onboarding the app is stuck on the verification screen because there is a permanent loading screen and the skip verification modal doesn't show up. I copied the modal so that it's shown even if the screen is loading.
Note: This is blocking the wallet e2e tests.
Tested
Manually and added a unit test.
Related issues