[Wallet] Fix invite flow and i18n texts #5232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i1skn
requested review from
cmcewen,
jeanregisser and
jmrossy
as code owners
gnardini
approved these changes
Sep 29, 2020
tarikbellamine
added
wallet
automerge
tarikbellamine
changed the title
tarikbellamine
pushed a commit
that referenced
this pull request
Sep 29, 2020
### Description Fix to the issue reported in Slack: > I found an issue on the invite redemption flow: After redeeming an invite code, if I try to verify my number I get a "Verification Failed" error immediately. If I skip verification but then verify by tapping on the notification box or the settings menu verification works well. Attaching logs, the relevant line seems to be identity/verification :: Error occured during verification flow :: invalid bytes32 value (arg="identifier", coderType="bytes32", value="") in throwError@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:299691:26 This is reproduced 100% on iOS emulator, trying now on Android device. ### Other changes Address Jean's comments in #5134 ### Related Issues - Closes #5228 ### Tested iOS simulator ### Backwards compatibility Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix to the issue reported in Slack:
Other changes
Address Jean's comments in #5134
Related Issues
Tested
iOS simulator
Backwards compatibility
Yes