[Wallet] Go back to VerificationEducation screen without updating the state #5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fetching verification state also on going back to VerificationEducation screen, not only at the first time screen loads.
i1skn
requested review from
cmcewen,
jeanregisser and
jmrossy
as code owners
cmcewen
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
This looks good to me. Wondering if we can add some sort of test coverage for all the edge cases you've been working through - I know @gnardini has been working on e2es for verification, but just would be nice to make sure these fixes stay fixed 😄
gnardini
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
LGTM :)
For the edge cases, I think we could add a unit test for this rather than an e2e one, I see there are some for this screen but none with the hideOnboardingStep flag as true.
e2e tests for the verification flow are going to be very tough to get right and will probably be extremely flaky because of the SMS verification
ewilz
pushed a commit
to ewilz/celo-monorepo
that referenced
this pull request
Sep 29, 2020
… state (celo-org#5177) ### Description Add fetching verification state also on going back to VerificationEducation screen, not only at the first time screen loads. ### Other changes * Disable "Back" button on Verification screen during onboarding. If user landed there it means account is already created (phrase imported or invite redeemed). ### Tested iOS simulator ### Related issues - Fixes celo-org#5166 ### Backwards compatibility Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add fetching verification state also on going back to VerificationEducation
screen, not only at the first time screen loads.
Other changes
Tested
iOS simulator
Related issues
Backwards compatibility
Yes