upgrade React-native-web to 13 #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmgdr
requested review from
asaj,
cmcewen and
timmoreton
as code owners
aaronmgdr
requested review from
ErinHales
and removed request for
timmoreton,
jmrossy,
cmcewen and
asaj
ErinHales
reviewed
Sep 16, 2020
|
Also, noticed |
|
Error when starting up the site |
ErinHales
approved these changes
Sep 17, 2020
m-chrzan
pushed a commit
that referenced
this pull request
Sep 19, 2020
### Description
upgrades react-native-web from 0.11 to 0.13.
### Other changes
only made changes nessesary to get the tests and functionality to work
* remove the custom `onPress` testing fireEvent as `fireEvent.click` now works
* Changed what Form onInput expects from a native event to a custom`{name, value}` as `nativeEvent` no longer included the input `name` nor was it to be found elsewhere on the event.
### Tested
ran the tests, fixed the test
went to every page and interacted, filled out forms. etc.
### Related issues
- Fixes #3005
### Backwards compatibility
should be
ewilz
pushed a commit
to ewilz/celo-monorepo
that referenced
this pull request
Sep 29, 2020
### Description
upgrades react-native-web from 0.11 to 0.13.
### Other changes
only made changes nessesary to get the tests and functionality to work
* remove the custom `onPress` testing fireEvent as `fireEvent.click` now works
* Changed what Form onInput expects from a native event to a custom`{name, value}` as `nativeEvent` no longer included the input `name` nor was it to be found elsewhere on the event.
### Tested
ran the tests, fixed the test
went to every page and interacted, filled out forms. etc.
### Related issues
- Fixes celo-org#3005
### Backwards compatibility
should be
This was referenced Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrades react-native-web from 0.11 to 0.13.
Other changes
only made changes nessesary to get the tests and functionality to work
remove the custom
onPresstesting fireEvent asfireEvent.clicknow worksChanged what Form onInput expects from a native event to a custom
{name, value}asnativeEventno longer included the inputnamenor was it to be found elsewhere on the event.Tested
ran the tests, fixed the test
went to every page and interacted, filled out forms. etc.
Related issues
Backwards compatibility
should be