[Wallet] keep awake verification loading screen + fix upgrade screen #5007
Conversation
i1skn
requested review from
aaronmgdr,
cmcewen,
jeanregisser and
jmrossy
as code owners
|
That language is pretty scary. Is that what we want? @nityas |
There was a problem hiding this comment.
Based on the Valora voice guidelines Im going to say we should not merge this until we have wording that fits those guidelines.
possible suggestion
"Valora is now more secure."
even that might not be right.
https://docs.google.com/document/d/1CbB2r2tmdLXKrzxMe5b7qm1SziSDkP8w7s7pfhSKWEU/edit#
There was a problem hiding this comment.
Code changes LGTM but like @aaronmgdr said would be good to get confirmation on wording while we're editing this screen anyway. Initial version was hastily put together.
|
Thanks for the flag |
|
@aaronmgdr @jmrossy I've updated the wording, PTAL |
| static navigationOptions = { | ||
| ...headerWithCloseButton, | ||
| } |
There was a problem hiding this comment.
Looks like we didn't want this screen to be closed.
Sure we want to change this now?
There was a problem hiding this comment.
Well, otherwise there is no way to close this screen if you are not in the mood of updating atm
| export function navigateToWalletStorePage() { | ||
| if (Platform.OS === 'android') { | ||
| navigateToURI(`market://details?id=${DeviceInfo.getBundleId()}`) | ||
| } else { | ||
| navigateToURI(`https://apps.apple.com/app/id${APP_STORE_ID}`) | ||
| } |
…elo-org#5007) ### Description Keep awake verification loading screen. ### Other changes Fix design in `Upgrade` screen, fix it for iOS. ### Tested iOS and Android physical devices ### Related issues - Fixes celo-org#5001 ### Backwards compatibility Yes ### Screenshot 
|
Hi @tarikbellamine I have verified this Task on latest test flight build (25) & Android internal build Android internal build 1.2.0(1004294313) and observe the following:
Fix design in Upgrade screen, fix it for iOS
Note: Currently, we have 1.2.0 internal build for Android and IOS. please let me know if i need to verify with another steps to get the screen |
|
@jeanregisser how can Ankit prompt this? |
Description
Keep awake verification loading screen.
Other changes
Fix design in
Upgradescreen, fix it for iOS.Tested
iOS and Android physical devices
Related issues
Backwards compatibility
Yes
Screenshot