[L13] Not using the SafeMath library #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorhodes
approved these changes
Sep 8, 2020
| @@ -1,10 +1,13 @@ | |||
| pragma solidity ^0.5.8; | |||
|
|
|||
| import "openzeppelin-solidity/contracts/token/ERC20/IERC20.sol"; | |||
| import "openzeppelin-solidity/contracts/math/SafeMath.sol"; | |||
There was a problem hiding this comment.
these changes are probably harmless but to clarify, these specs are only used in the certora-test formal verification and the contracts are never deployed on network afaik
There was a problem hiding this comment.
thanks, useful information
ewilz
commented
Sep 8, 2020
ewilz
force-pushed
the
l13
branch
2 times, most recently
from
9cf54a9 to
725e5cb
Compare
Codecov Report
|
ewilz
added a commit
that referenced
this pull request
Sep 29, 2020
* [L13] Not using the SafeMath library * Fix ++ typo * Add versioning * Fix inheritance graph * Further fix rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add safemath where possible
Other changes
Added
ICeloVersionedContractinterface toUsingPrecompilesTested
N/A should remain working as expected
Related issues
Backwards compatibility
N/A should remain working as expected