Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L01] Frozen function can be bypassed #587 #4910

Merged
merged 4 commits into from
Sep 11, 2020
Merged

Conversation

yorhodes
Copy link
Contributor

Description

A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

@yorhodes yorhodes changed the base branch from master to oz-prerelease August 31, 2020 23:56
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (oz-prerelease@d8a4224). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             oz-prerelease    #4910   +/-   ##
================================================
  Coverage                 ?   74.84%           
================================================
  Files                    ?      323           
  Lines                    ?    10307           
  Branches                 ?     1042           
================================================
  Hits                     ?     7714           
  Misses                   ?     2425           
  Partials                 ?      168           
Flag Coverage Δ
#mobile 74.84% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a4224...69afcba. Read the comment docs.

@yorhodes yorhodes merged commit a1d6bca into oz-prerelease Sep 11, 2020
ewilz pushed a commit that referenced this pull request Sep 29, 2020
* Remove onlyWhenNotFrozen on view functions

* Bump patch versions

* Implement ICeloVersionedContract in EpochRewards

* Remove freezable from election
@yorhodes yorhodes deleted the yorhodes/L01 branch June 1, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants