Dappkit Redesign #4793
Merged
Dappkit Redesign #4793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medhakothari
requested review from
cmcewen,
i1skn,
jeanregisser and
jmrossy
as code owners
jeanregisser
suggested changes
Aug 28, 2020
|
Thanks for the helpful comments @jeanregisser! Didn't know fonts v2 existed, switched to that now! Also changed the button styling and tested on smaller screens, works now :)
|
jeanregisser
approved these changes
Aug 31, 2020
annakaz
approved these changes
Sep 1, 2020
|
@jeanregisser Can you please provide a build details to verify task. thanks! |
ewilz
pushed a commit
to ewilz/celo-monorepo
that referenced
this pull request
Sep 29, 2020
* made changes to account screen * changed sign txn screen * fixed data screen * added spanish translations * Update global.json * Update global.json * changed to fonts v2 * no inline button styling Co-authored-by: Medha Kothari <[email protected]> Co-authored-by: Medha Kothari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses styles similar to the rest of Valora, follows the designs here
Other changes
n/a
Tested
Before:
After:
Related issues
Backwards compatibility
none