[Wallet] Implement explanations of the fees and use fee drawer on exchanges #4429
Conversation
i1skn
changed the title
| @@ -39,7 +39,8 @@ export const getExchangeRateDisplayValue = (value: BigNumber.Value): string => { | |||
|
|
|||
| export const getFeeDisplayValue = (value: BigNumber.Value | null | undefined): string => { | |||
| return value | |||
There was a problem hiding this comment.
Does value evaluate to false for any non-zero values? Wondering whether the case below is ever used for non-zero values
There was a problem hiding this comment.
When value is a BigNumber it would evaluate to true independently of the value in it.
| @@ -1672,7 +1672,7 @@ exports[`TransferConfirmationCard renders correctly for sent escrow transaction | |||
| > | |||
|
|
|||
| $ | |||
| 0.001 | |||
| 0 | |||
There was a problem hiding this comment.
Confirming that this change is expected as we now only round up to 0.001 if it is non zero?
There was a problem hiding this comment.
Well, this is a tough question. When fee is precisely zero, do we want still to show 0.001? cc: @cmcewen @jmrossy @jeanregisser
There was a problem hiding this comment.
After talking with @cmcewen I'm proposing the following: fees should not be zero in the long run, but now we have tobin tax set to zero and transaction fee is not present in the blockchain api for exchanges. @nityas also has agreed to if the value is exactly 0 - show zero. In the future these fees should be non-zero. Let me know what do you think? cc: @annakaz
Description
Implement Dialog with fee explanation when use clicks on "?" icon next to a fee.
Other changes
<FeeDrawer />for ExchangesTested
iOS Simulator
Backwards compatibility
Yes
Screenshots