[BlockchainApi] Fix exchange transactions #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make logic work if fees are paid in the utility token (cGLD) - throw when any assertion is wrong
…ockchain-api-exchanges
Codecov Report
@@ Coverage Diff @@
## master #3565 +/- ##
==========================================
+ Coverage 74.79% 74.87% +0.07%
==========================================
Files 622 622
Lines 15848 15828 -20
Branches 1739 2055 +316
==========================================
- Hits 11854 11851 -3
+ Misses 3618 3604 -14
+ Partials 376 373 -3
Continue to review full report at Codecov.
|
jmrossy
approved these changes
Apr 23, 2020
| } | ||
| break | ||
|
|
||
| case 2: // Exchange events have two corresponding transfers (in and out) |
There was a problem hiding this comment.
Could this large function be broken apart? I'm not sure having a big chunk of code in a switch case is best for readability
| }) | ||
| default: | ||
| // Warn if anything else happens | ||
| console.warn(`Unhandled transfers for tx ${transferTx.transactionHash}`) |
There was a problem hiding this comment.
Nit: maybe error here? We should probably set up alerts for this. Having an error code enum defined somewhere would help with that
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2020
### Description The notification service was picking the wrong address for the transfer, because of the events which changed at the transaction layer, similar to what we had to fix in `blockchain-api` in #3565. Each transaction contains the actual transfer and also fee transfers. The previous code was only considering the last transfer emitted for the transaction, which was a fee transfer. Note: we could also filter out fee transfers like we did for `blockchain-api`, but there's no harm leaving them for now (they won't have any matching fcm token). ### Other changes - Don't create a Sentry event when a notification is received while in background. There is nothing that needs to be done. (Example: https://sentry.io/organizations/celo/issues/1648609728/?project=1250733&query=is%3Aunresolved) ### Tested - Deployed on Alfajores: - Push notifications are sent again to the correct user address when sending money. ### Related issues - Fixes #1339 ### Backwards compatibility Yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restores functionality for the wallet activity feed regarding exchange transactions.
The existing API we used broke because there are now events emitted when paying for fees in cUSD. See discussion in https://celo-org.slack.com/archives/CMX4JFMQW/p1586526953169900
A new API has been added to blockscout in order to get all cUSD and cGLD transfers happening in transactions.
This work has been done by @mrsmkl in celo-org/blockscout#102 which has already been deployed on alfajores.
For transactions paying for fees in cUSD we try to detect transfers related to fees (validator, gateway fee recipient, community fund).
This has risks of breaking, so I've put assertions so we can detect if it happens in the future.
Other changes
Tested
Deployed on alfajores and tested successfully.
Related issues
eventsquery #2509Backwards compatibility
Yes