Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address flaky docker builds #2777

Merged
merged 11 commits into from
Feb 18, 2020
Merged

Address flaky docker builds #2777

merged 11 commits into from
Feb 18, 2020

Conversation

jfoutts-celo
Copy link
Contributor

@jfoutts-celo jfoutts-celo commented Feb 13, 2020 •
edited
Loading

Description

Address flaky docker builds by:

Tested

Tested that kaniko docker builds succeed.

Related issues

Part of epic celo-org/celo-blockchain#847 Builds reliably green

@codecov
Copy link

codecov bot commented Feb 13, 2020 •
edited
Loading

Codecov Report

Merging #2777 into master will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2777      +/-   ##
=========================================
- Coverage   74.01%     74%   -0.01%     
=========================================
  Files         559     559              
  Lines       13944   13945       +1     
  Branches     1436    1375      -61     
=========================================
  Hits        10320   10320              
- Misses       3341    3343       +2     
+ Partials      283     282       -1
Flag Coverage Δ
#mobile 74.11% <25%> (-0.01%) ⬇️
#web 73.84% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/web/src/shared/SocialChannels.tsx 69.09% <ø> (ø) ⬆️
packages/web/src/header/OpenGraph.tsx 100% <ø> (ø) ⬆️
packages/mobile/src/import/ImportWallet.tsx 88.46% <0%> (-1.74%) ⬇️
packages/mobile/src/invite/saga.ts 72.43% <100%> (ø) ⬆️
packages/web/src/utils/abortableFetch.ts 71.42% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6f8b85...51c9737. Read the comment docs.

@nategraf nategraf assigned jfoutts-celo and unassigned nategraf Feb 14, 2020
@jfoutts-celo jfoutts-celo requested a review from yerdua as a code owner February 18, 2020 18:21
jcortejoso
jcortejoso approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@jcortejoso jcortejoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 LGTM! Thanks!

@jcortejoso jcortejoso added the automerge Have PR merge automatically when checks pass label Feb 18, 2020
@celo-ci-bot-user celo-ci-bot-user merged commit 3758ab7 into master Feb 18, 2020
@celo-ci-bot-user celo-ci-bot-user deleted the jfoutts/kaniko-v0.16.0 branch February 18, 2020 19:08
aaronmgdr added a commit that referenced this pull request Feb 19, 2020
@aaronmgdr
Merge branch 'master' into aarongmgdr/sdk-page
5bd6cc0 
* master:
  Add Validators list page to website (#2478)
  [C02] Any owner of the Multisig can execute unconfirmed transactions (#2808)
  Address flaky docker builds (#2777)

# Conflicts:
#	packages/web/src/header/Header.3.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcortejoso jcortejoso jcortejoso approved these changes

@yerdua yerdua Awaiting requested review from yerdua

Assignees

@jfoutts-celo jfoutts-celo

Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jfoutts-celo @jcortejoso @nategraf @celo-ci-bot-user