[NotificationService] Change exchange rate stored format (group by pair) #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or a given time range
Similar gains as seen in #2005
jmrossy
approved these changes
Dec 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #2132 +/- ##
=======================================
Coverage 74.88% 74.88%
=======================================
Files 281 281
Lines 7807 7807
Branches 686 686
=======================================
Hits 5846 5846
Misses 1845 1845
Partials 116 116
Continue to review full report at Codecov.
|
…der-currency-pair
…under-currency-pair
celo-ci-bot-user
deleted the
jeanregisser/group-stored-exchange-rate-under-currency-pair
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #1945
Firebase RTDB querying capabilities are quite limited, once we query a specific time range using
orderByChild, we can't then filter on a specific pair.So here we workaround that problem by storing exchange rates under their pair.
Tested
Deployed on integration.
Before
After
Other changes
Speed up jest tests, similar to what's been done in #2005
Related issues
Backwards compatibility
No. I'm deleting existing stored exchange rates in firebase when deploying this.
This is safe to do at this point since there's no consumer of this data yet.