Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forno urls everywhere #2064

Merged
merged 3 commits into from
Dec 6, 2019

Conversation

jeanregisser
Copy link
Contributor

@jeanregisser jeanregisser commented Dec 5, 2019

Description

There were some outdated references to infura.

Tested

for env in integration alfajores alfajoresstaging pilot pilotstaging baklava baklavastaging; do curl --fail -l https://$env-forno.celo-testnet.org && echo "https://$env-forno.celo-testnet.org ✅" || echo "https://$env-forno.celo-testnet.org ⚠️"; done
https://integration-forno.celo-testnet.org ✅
https://alfajores-forno.celo-testnet.org ✅
https://alfajoresstaging-forno.celo-testnet.org ✅
https://pilot-forno.celo-testnet.org ✅
https://pilotstaging-forno.celo-testnet.org ✅
https://baklava-forno.celo-testnet.org ✅
curl: (60) SSL certificate problem: self signed certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
https://baklavastaging-forno.celo-testnet.org ⚠️

Other changes

  • Removed unnecessary trailing slash
  • Fix missing config for notification-service pilotstaging

Backwards compatibility

Yes

Copy link
Contributor

@annakaz annakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@annakaz
Copy link
Contributor

annakaz commented Dec 5, 2019

May want to wait to redeploy blockchain-api (if we were planning a redeploy) until https://pilot-forno.celo-testnet.org and https://pilotstaging-forno.celo-testnet.org are back up

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #2064 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2064   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files         281      281           
  Lines        7824     7824           
  Branches      687      687           
=======================================
  Hits         5823     5823           
  Misses       1884     1884           
  Partials      117      117
Flag Coverage Δ
#mobile 74.42% <100%> (ø) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/config.ts 88.37% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c1368...5ff4ec9. Read the comment docs.

@jeanregisser jeanregisser added the automerge Have PR merge automatically when checks pass label Dec 6, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit 46fdb49 into master Dec 6, 2019
@celo-ci-bot-user celo-ci-bot-user deleted the jeanregisser/use-forno-urls-everywhere branch December 6, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants