Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #1855

Merged
merged 3 commits into from
Nov 25, 2019
Merged

Fix typos #1855

merged 3 commits into from
Nov 25, 2019

Conversation

m-chrzan
Copy link
Contributor

Just fixing a few typos in comments I noticed while browsing the codebase.

@m-chrzan m-chrzan requested a review from asaj as a code owner November 25, 2019 15:26
Copy link
Collaborator

@rcroessmann rcroessmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@m-chrzan m-chrzan added the automerge Have PR merge automatically when checks pass label Nov 25, 2019
@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f551fcd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1855   +/-   ##
========================================
  Coverage          ?   74.2%           
========================================
  Files             ?     278           
  Lines             ?    7653           
  Branches          ?     956           
========================================
  Hits              ?    5679           
  Misses            ?    1857           
  Partials          ?     117
Flag Coverage Δ
#mobile 74.2% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f551fcd...9d978e5. Read the comment docs.

@celo-ci-bot-user celo-ci-bot-user merged commit 548bc26 into master Nov 25, 2019
@celo-ci-bot-user celo-ci-bot-user deleted the m-chrzan/accounts-typos branch November 25, 2019 22:21
aaronmgdr added a commit that referenced this pull request Nov 26, 2019
* master: (61 commits)
  [Wallet] Handle `/v/<code` deep links for phone verifications (#1776)
  Patch tslint auto fix for macOS Catalina until tslint#6.x is out (#1802)
  Fix typos (#1855)
  Update documentation sidebar (#1861)
  [Wallet] Update forno dev documentation (#1818)
  [Docs] Correct typo
  Validator UX docs for baklava network (#1688) (#1849)
  Various improvements to the CLI, allow voters to revote for a group (#1840)
  Serialize to hex string (#1848)
  Update faucet to pull from the reserve when possible (#1844)
  Fix elect validators migration, deploy integration (#1847)
  Configurable genesis balances (#1838)
  Deploy new version of Celostats and minnor change from celo-blockchain (#1714)
  Make default node URL consistent in celocli (#1805)
  Onboarding feedback (#1811)
  return at least true, when the function is returning bool (#1825)
  Minor Contractkit changes (#1819)
  Point end-to-end tests back to master (#1824)
  Update migration config to correct protocol parameters (#1822)
  Update with new istanbul lookback window size flag (#1820)
  ...

# Conflicts:
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants