Explicitly wait for nodes to sync in end-to-end tests #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
November 16, 2019 12:40
Codecov Report
@@ Coverage Diff @@
## master #1752 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 277 277
Lines 7617 7617
Branches 669 669
=======================================
Hits 5657 5657
Misses 1845 1845
Partials 115 115
Continue to review full report at Codecov.
|
nategraf
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a source of flakiness in which nodes would try to send transactions without being synced.