Support blacklisting country codes for the attestation service #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1738 +/- ##
========================================
Coverage 74.26% 74.26%
========================================
Files 277 277
Lines 7617 7617
Branches 953 669 -284
========================================
Hits 5657 5657
Misses 1845 1845
Partials 115 115
Continue to review full report at Codecov.
|
jmrossy
reviewed
Nov 15, 2019
|
|
||
| - `DATABASE_URL` - The URL under which your database is accessible, currently supported are `postgres://`, `mysql://` and `sqlite://` | ||
| - `CELO_PROVIDER` - The URL under which a celo blockchain node is reachable, i.e. something like `https://integration-forno.celo-testnet.org` | ||
| - `ACCOUNT_ADDRESS` - The address of the account on the `Accounts` smart contract |
There was a problem hiding this comment.
Can we get this from contract kit?
There was a problem hiding this comment.
I can see how the phrasing is confusing. It's not the address of the Accounts smart contract, but the account address of the validator account on the Accounts smart contract. Not sure what a better name/description would be
jmrossy
approved these changes
Nov 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary objective of this PR is to support #1446, to allow validators to blacklist locales they do not want to serve, primarily for cost reasons if some locales are too prohibitive for them to serve.
Tested
namoffchainrevealOther changes
Related issues
Backwards compatibility