-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Version for contractkit #1727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcortesi
force-pushed
the
mc/new-ck-version
branch
from
November 14, 2019 18:32
d3400d9
to
41a1c2e
Compare
jmrossy
approved these changes
Nov 14, 2019
mcortesi
force-pushed
the
mc/new-ck-version
branch
from
November 14, 2019 18:44
41a1c2e
to
1925341
Compare
nambrot
approved these changes
Nov 14, 2019
mcortesi
force-pushed
the
mc/new-ck-version
branch
from
November 14, 2019 23:20
1925341
to
4e96a6e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1727 +/- ##
========================================
Coverage 74.26% 74.26%
========================================
Files 277 277
Lines 7617 7617
Branches 669 953 +284
========================================
Hits 5657 5657
Misses 1845 1845
Partials 115 115
Continue to review full report at Codecov.
|
- Freeze cross-fetch version via a yarn resolution. - [blockchain-api] Use last deployed version of contractKit - [transaction-metrics-exporter] Use last deployed version of contractKit
aaronmgdr
added a commit
that referenced
this pull request
Nov 15, 2019
* master: (81 commits) Make styling more consistent in validator quick start and add password prompt to account:unlock (#1731) New Version for contractkit (#1727) Remove end-to-end attestations test from circle (#1739) Added helper function to get the list of current validators (#1713) Fix flaky end-to-end transfer, protocol unit tests (#1734) Add AccountClaim to Metadata (#1663) [Wallet] Set default gradle properties (#1629) Update genesis block after adding parent signatures to block header (#1732) Removed end-to-end-geth-integration-sync-test job in workflow (#1730) Change the event we emit when selecting issuers (#1706) [Wallet] Prompt user to restart app when turning off Forno a second time (#1708) Check in spanish verification translations (#1726) [Wallet] Style fixes on iOS for verification and backup flows (#1718) [Wallet] Reset isRedeemingInvite on rehydrate (#1716) Adjust e2e transfer and governance tests to match new fee distribution and eliminate ProposerFraction (#1585) [Wallet] Add more local currencies (#1698) Switch to correct cluster when fauceting (#1687) [Wallet] Use the country of the phone number for determining the default local currency (#1684) [Wallet] Limit QR code scanner to 1 code per second (#1676) Update Dark backgrounds text color (#1677) ... # Conflicts: # packages/web/pages/_app.tsx # packages/web/src/dev/BuildPage.tsx # packages/web/src/dev/Cover.tsx # packages/web/src/dev/StackSection.tsx # yarn.lock
aaronmgdr
added a commit
that referenced
this pull request
Nov 26, 2019
* master: (70 commits) Make styling more consistent in validator quick start and add password prompt to account:unlock (#1731) New Version for contractkit (#1727) Remove end-to-end attestations test from circle (#1739) Added helper function to get the list of current validators (#1713) Fix flaky end-to-end transfer, protocol unit tests (#1734) Add AccountClaim to Metadata (#1663) [Wallet] Set default gradle properties (#1629) Update genesis block after adding parent signatures to block header (#1732) Removed end-to-end-geth-integration-sync-test job in workflow (#1730) Change the event we emit when selecting issuers (#1706) [Wallet] Prompt user to restart app when turning off Forno a second time (#1708) Check in spanish verification translations (#1726) [Wallet] Style fixes on iOS for verification and backup flows (#1718) [Wallet] Reset isRedeemingInvite on rehydrate (#1716) Adjust e2e transfer and governance tests to match new fee distribution and eliminate ProposerFraction (#1585) [Wallet] Add more local currencies (#1698) Switch to correct cluster when fauceting (#1687) [Wallet] Use the country of the phone number for determining the default local currency (#1684) [Wallet] Limit QR code scanner to 1 code per second (#1676) Update Dark backgrounds text color (#1677) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Freezes all last changes on ContractKit on a new Version 0.2.
For all packages that depended on the "git version", they now depend on the "0.2.1-dev" which signal the git unpublished version.
The rest of the packages were not updated, since they depended on the 0.1.6 npm version from a few months ago. Probably an alfajores one
@asaj It would be nice if we avoid squashing the commits here. Since first commits represents the npm new version (and should be tagged) and the second commit is the start of the next dev cycle.
Tested
CI / Build