Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI command to update validator public key #1626

Merged
merged 6 commits into from
Nov 9, 2019
Merged

Add CLI command to update validator public key #1626

merged 6 commits into from
Nov 9, 2019

Conversation

asaj
Copy link
Contributor

@asaj asaj commented Nov 7, 2019

Description

This PR adds a smart contract function and corresponding CLI command for validators to update their public keys.

Note that this update will not affect the existing epoch, only future epochs.

Tested

Unit tests.

Other changes

None

Related issues

Backwards compatibility

Technically backwards compatible

@asaj
Copy link
Contributor Author

asaj commented Nov 7, 2019

@kevjue, we'll need to update ValidatorSetDiff to return a diff if the BLS public key changes. Any other celo-blockchain changes you can think of?

nambrot
nambrot approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@nambrot nambrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor refactor suggestion

packages/protocol/contracts/governance/Validators.sol Show resolved Hide resolved
@nambrot nambrot assigned asaj and unassigned nambrot Nov 7, 2019
@codecov
Copy link

codecov bot commented Nov 9, 2019 •
edited
Loading

Codecov Report

Merging #1626 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1626    +/-   ##
========================================
  Coverage   74.23%   74.23%            
========================================
  Files         287      287            
  Lines        7704     7704            
  Branches      960      667   -293     
========================================
  Hits         5719     5719            
  Misses       1871     1871            
  Partials      114      114
Flag Coverage Δ
#mobile 74.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b7e0d...f82f056. Read the comment docs.

@asaj asaj added the automerge Have PR merge automatically when checks pass label Nov 9, 2019
@asaj asaj unassigned kevjue Nov 9, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit cda5aaa into master Nov 9, 2019
@celo-ci-bot-user celo-ci-bot-user deleted the asaj/bls-key branch November 9, 2019 19:45
@asaj asaj mentioned this pull request Nov 10, 2019
Merged
This was referenced Jun 20, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcortesi mcortesi mcortesi approved these changes

@nambrot nambrot nambrot approved these changes

@m-chrzan m-chrzan Awaiting requested review from m-chrzan

Assignees

@asaj asaj

Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow validators to change BLS key
5 participants
@asaj @nambrot @mcortesi @kevjue @celo-ci-bot-user