[Wallet] Implement most of verification loading screen and skip modal #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use updated RN Geth to support hot reloading
…component Clean up related fonts and styles Implement VerificationEducationScreen
Implement skip modal in verification education screen Implement most of verification loading screen Remove unused dropdown modal package
jmrossy
requested review from
jeanregisser,
cmcewen,
annakaz,
i1skn and
martinvol
Codecov Report
@@ Coverage Diff @@
## master #1566 +/- ##
==========================================
+ Coverage 73.86% 73.94% +0.08%
==========================================
Files 283 284 +1
Lines 7537 7565 +28
Branches 954 955 +1
==========================================
+ Hits 5567 5594 +27
- Misses 1858 1859 +1
Partials 112 112
Continue to review full report at Codecov.
|
cmcewen
reviewed
Nov 5, 2019
packages/mobile/ios/Podfile.lock
Outdated
| @@ -389,8 +392,6 @@ PODS: | |||
| - React | |||
| - RNPermissions (2.0.2): | |||
| - React | |||
| - RNRandomBytes (3.0.0): | |||
There was a problem hiding this comment.
Do you know why this is being removed?
There was a problem hiding this comment.
No but we don't seem to use it. Not sure why my cocopods removed it when Jean's didn't
| @@ -99,8 +101,7 @@ | |||
| "react-native-keyboard-aware-scroll-view": "^0.9.1", | |||
| "react-native-localize": "^1.3.0", | |||
| "react-native-mail": "^4.0.0", | |||
| "react-native-modal": "^11.4.0", | |||
| "react-native-modal-dropdown": "^0.7.0", | |||
| expect(tree).toMatchSnapshot() | ||
| expect(toJSON()).toMatchSnapshot() | ||
|
|
||
| // And snapshot again after showing the modal |
| class VerificationLoadingScreen extends React.Component<Props> { | ||
| static navigationOptions = { header: null } | ||
|
|
||
| onCancel = () => { |
There was a problem hiding this comment.
We cancel the verification saga and go back to the education screen. Will do in next PR
jeanregisser
previously requested changes
Nov 6, 2019
jmrossy
force-pushed
the
rossy/wa-ver-loading
branch
from
90b2be1 to
c23439a
Compare
jeanregisser
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested
Relevant screens tested locally
still TODO test iOS, will do after done verification implementation
Related issues
Backwards compatibility
Yes