Set usage of shuffled round robin in the genesis block #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmoreton
approved these changes
Oct 24, 2019
nategraf
force-pushed
the
victor/use-the-shuffle
branch
from
776201d to
5a99d08
Compare
Codecov Report
@@ Coverage Diff @@
## master #1464 +/- ##
=======================================
Coverage 65.39% 65.39%
=======================================
Files 271 271
Lines 8187 8187
Branches 570 570
=======================================
Hits 5354 5354
Misses 2711 2711
Partials 122 122
Continue to review full report at Codecov.
|
tkporter
approved these changes
Oct 25, 2019
|
Added a comment explaining what the number means |
This reverts commit 73e1558.
nategraf
force-pushed
the
victor/use-the-shuffle
branch
from
7bbac9e to
20ef38d
Compare
aaronmgdr
added a commit
that referenced
this pull request
Oct 29, 2019
…repo into aaronmgdr/invite-page * 'aaronmgdr/invite-page' of github.com:celo-org/celo-monorepo: (63 commits) Fix compile error during local clean build (#1506) Update to RN 61 and AndroidX (#1343) Set usage of shuffled round robin in the genesis block (#1464) Add spanish backup key for backup key flow (#1500) Fix sync tests by pulling genesis block to determine epoch length (#1504) [Wallet] fix missing full name error alert (#1496) [Wallet + Verification Pool] Add details about generating an app-signature (#1482) Deploy celo's image of ethstats (#1421) Storing previous randomness values (#1197) [Wallet] Fix wei invite bug (#1489) Point all packages to latest ganache-cli master (#1488) Point end-to-end tests back to master (#1469) [Wallet] Migrate app view functions to contractkit (#1381) [Wallet] Add script to translate locale strings (#1485) [Wallet] Update wallet celo client version and add missing translations for backup flow (#1483) [Wallet] Hotfix local currency (#1481) [Wallet] Remove QR debouncing to improve responsiveness (#1480) [Wallet] Upgrade app version to v1.5.1 (#1463) Update governance end-to-end tests to work with changed precompile (#1476) Fixes key_placer.sh when encrypting files (#1465) ...
This was referenced Jul 31, 2022
This was referenced Oct 6, 2022
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR celo-org/celo-blockchain#536 introduces the shuffled round robin ordering option as a new proposer policy within Istanbul. Configuration of the ordering policy is set in the genesis block.
Tested
Deployed a testnet and verified that blocks are produced and the proposer ordering is pseudo-random.
Related issues
Backwards compatibility
This PR only changes the defaults for new chains