Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet] If an action is in the blacklist, now only logs the name (but not the payload) #1338

Merged
merged 3 commits into from
Oct 15, 2019

Conversation

martinvol
Copy link
Contributor

Description

If an action is in the blacklist, then it was not logged at all. This can cause confuse developers as they might be lead to thing their action was not triggered at all.

Also helps debugging, as the logs are now completed.

Tested

  • They don't show up in the logs

Other changes

Related issues

Backwards compatibility

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #1338 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1338      +/-   ##
=========================================
- Coverage   66.41%   66.4%   -0.01%     
=========================================
  Files         264     264              
  Lines        7745    7746       +1     
  Branches      444     513      +69     
=========================================
  Hits         5144    5144              
+ Misses       2502    2501       -1     
- Partials       99     101       +2
Flag Coverage Δ
#mobile 66.4% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
packages/mobile/src/redux/sagas.ts 83.33% <0%> (-1.78%) ⬇️
packages/mobile/src/utils/formatting.ts 89.74% <0%> (ø) ⬆️
packages/mobile/src/identity/reducer.ts 41.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a58d510...34e9aaf. Read the comment docs.

@martinvol martinvol added the automerge Have PR merge automatically when checks pass label Oct 15, 2019
@ashishb ashishb merged commit 833c2d3 into master Oct 15, 2019
@ashishb ashishb deleted the martinvol/wallet-log-all-actions branch October 15, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants