-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wallet] If an action is in the blacklist, now only logs the name (but not the payload) #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1338 +/- ##
=========================================
- Coverage 66.41% 66.4% -0.01%
=========================================
Files 264 264
Lines 7745 7746 +1
Branches 444 513 +69
=========================================
Hits 5144 5144
+ Misses 2502 2501 -1
- Partials 99 101 +2
Continue to review full report at Codecov.
|
jmrossy
approved these changes
Oct 15, 2019
This was referenced May 17, 2023
This was referenced Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an action is in the blacklist, then it was not logged at all. This can cause confuse developers as they might be lead to thing their action was not triggered at all.
Also helps debugging, as the logs are now completed.
Tested
Other changes
Related issues
Backwards compatibility