Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooling for CR12 release #11315

Merged
merged 12 commits into from
Jan 23, 2025
Merged

Fix tooling for CR12 release #11315

merged 12 commits into from
Jan 23, 2025

Conversation

martinvol
Copy link
Contributor

@martinvol martinvol commented Jan 22, 2025 •
edited
Loading

  1. Small changes to support CR12 nuances
  2. Fixes a bug that was releasing the wrong version for 0.8 contracts

martinvol
martinvol commented Jan 22, 2025
View reviewed changes
packages/protocol/contracts-0.8/governance/interfaces/IValidatorsInitializer.sol Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got moved so that truffle wouldn't break compiling

@martinvol martinvol marked this pull request as ready for review January 22, 2025 16:58
@martinvol martinvol requested a review from a team as a code owner January 22, 2025 16:58
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jan 22, 2025 •
edited
Loading

Fix tooling for CR12 release

Generated at commit: edf9a378b72566153b23df4874422255ad0d239e

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
2
0
14
43
62
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@martinvol martinvol merged commit 3fe2984 into release/core-contracts/12 Jan 23, 2025
39 of 42 checks passed
@martinvol martinvol deleted the martinvol/release12Tooling branch January 23, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pahor167 pahor167 pahor167 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinvol @pahor167