-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
general L2 test framework #11262
Merged
m-chrzan
merged 15 commits into
release/core-contracts/12
from
soloseng/general-framework
Oct 30, 2024
Merged
general L2 test framework #11262
m-chrzan
merged 15 commits into
release/core-contracts/12
from
soloseng/general-framework
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description Using test contract inheritance to minimize duplicated code during L2 testing ### Other changes removed unused var ### Tested unit tested ### Related issues - Fixes #[issue number here] ### Backwards compatibility _Brief explanation of why these changes are/are not backwards compatible._ ### Documentation _The set of community facing docs that have been added/modified because of this change_
This reverts commit b0058c5.
m-chrzan
approved these changes
Oct 28, 2024
Base automatically changed from
soloseng/streamline-election-L2-test
to
release/core-contracts/12
October 28, 2024 18:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brings reused setup code in multiple contracts under the same utils contract for testing
Other changes
moved mock file location
Tested
unit tested
Related issues