Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wallet] Preliminary iOS support #1098
[Wallet] Preliminary iOS support #1098
Changes from all commits
03f871f
9f8f627
dd84927
a363590
1893bfc
771cdf6
220b83a
e933d6f
d98083e
daa3101
aa9e795
49a820f
c7794c7
0db976c
7b7cad1
77e6a90
93a4fc7
cc5a439
a174fe4
2fe8e54
472cad1
e919bd9
d192f09
72db0fe
17490b5
8d7adfe
299d2b2
a7d41c4
83750d3
1cf4de6
d1b4a9a
839ec79
2480723
5eaa390
40c5c66
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Geth framework doesn't support bitcode. Not really a deal breaker, I tend to disable bitcode usually as it complicates crash reporting a little bit (you have to download the symbols after uploading the app to App Store Connect to be able to symbolicate stacktraces, It can (should) be automated anyway but takes longer in the CI pipeline).